eto-chip-explorer icon indicating copy to clipboard operation
eto-chip-explorer copied to clipboard

Revisit assertion vs warning in preprocessing script

Open jmelot opened this issue 2 years ago • 0 comments

I've moved to assertions in cases where we've discussed the check and should break preprocessing if it fails, but weshould be thoughtful about when we do this, as Neha notes below. I will think about this again later.

Not blocking. The general trend in this file has been to convert printed warnings to assert statements. Should this also become an assert someday?

Originally posted by @niharikasingh in https://github.com/georgetown-cset/eto-supply-chain/pull/110#discussion_r963933729

jmelot avatar Sep 06 '22 21:09 jmelot