kaldi-grpc-server icon indicating copy to clipboard operation
kaldi-grpc-server copied to clipboard

server/model dir should be emptied after each build (?)

Open manosplitsis opened this issue 3 years ago • 2 comments

When building a new docker image, the model directory is copied to server/model, but the user has to remove the contents manually to build from a different model dir

manosplitsis avatar Feb 24 '22 15:02 manosplitsis

Yes that's by design. Imagine the case where actually the user doesn't have a backup of the model and the script goes on to delete it. Its better be annoying and make the user make the conscious decision to delete their model.

We could include a cmd line flag (-y) to bypass this, or make the script ask for permission interactively. Feel free to post a pr

georgepar avatar Feb 24 '22 16:02 georgepar

TODO: Add a flag to remove old models during model building

georgepar avatar Mar 10 '22 09:03 georgepar