101-hello-worlds icon indicating copy to clipboard operation
101-hello-worlds copied to clipboard

Fix tests to accommodate multiple node versions

Open georgemandis opened this issue 2 years ago • 0 comments

Currently the following examples are failing:

  • 41
  • 45
  • 46

Those should be examined to make sure there isn’t in fact something broken with them, but for 41 and 46 at least the issues lies in globalThis not existing in the Node version the GH action runs in (See issue #14).

It’ll be cumbersome to fix, but I think moving each file into its own folder with a corresponding .nvmrc file might be the way forward (Or maybe use asdf if I’m feeling…fun?).

Once I do that and the template is there is shouldn’t be that hard to maintain going forward.

While I’m doing this I might want to reexamine the test suite and see if I can better accommodate more adventurous solutions.

georgemandis avatar Jun 10 '22 22:06 georgemandis