xwing
xwing copied to clipboard
geordanr
UI locks on Firefox Quantum on OSX 10.13 (High Sierra)
YASB Bug Report
Expected Behavior
Performance should not drop when adding/changing pilots.
Actual Behavior
UI is locked for ~6 seconds after adding a new pilot and/or changing an existing pilot. During this time none of the UI controls can respond to user interaction. I have observed that this doesn't happen on Chrome but have not tested other operating systems or older versions of Firefox.
Language
English
Here is a screenshot of the debug tools and a performance trace from when this is happening.
I did some more testing and eliminated the following potential issues:
- Using an older version of jquery and bootstrap. (I tested running with jquery and bootstrap 3 and the issue still persisted)
- Removing the
setIntervalused to updated permalinks
I also realized it's not limited to pilot selection as it also happens with the other dropdowns but not always and that while this is happening, there is a dramatic increase in CPU usage of the browser.
My current hunch is leaning towards this log that appears.
This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!
Is this happening only in Firefox or in other browsers? This sudden drop in performance is strange given there hasn't been a code update recently.
It’s not happening in Chrome on OSX. I suspect that’s it’s due to a change in Firefox itself but I’ve only tested it on two OSX machines running High Sierra. On Tue, Feb 13, 2018 at 6:23 PM Geordan Rosario [email protected] wrote:
Is this happening only in Firefox or in other browsers? This sudden drop in performance is strange given there hasn't been a code update recently.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geordanr/xwing/issues/560#issuecomment-365440135, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQRt0z-285C6hagu7K6v_EmQkGoi5OJks5tUhlrgaJpZM4SETtK .
I'm still using El Capitan for some reason, on a 2013 MacBook Pro. Rarely ever use Firefox, so I had a very old version installed still. It updated in steps, so I got to check some intermediate Firefox versions:
- 45.something, no performance issues
- 48.0.2, no performance issues
- 57.something, no issues
- 58.0.2 (current), no issues
After some more testing, I've discovered it doesn't happen if I log out. I've tried with both Facebook and Google and both exhibit the performance hit.
FF 58.0.2 on Ubuntu 17.04 (I know, I know) doesn't seem to have the issue, even if logged in via Google.
Logging in with Google and Facebook doesn't produce a slowdown on FF 58.0.2 with El Capitan, either.
I was able to reproduce the issue on my coworkers High Sierra machine so I can confirm that I’m not going crazy. It was not reproducible on my wife’s Sierra machine.
I was able to isolate it as something to with select2 and the collection returned from the backend. The issue presents itself even with an empty collection.
I will try to dig deeper tonight. On Thu, Feb 15, 2018 at 4:54 AM Guido Gloor Modjib [email protected] wrote:
Logging in with Google and Facebook doesn't produce a slowdown on FF 58.0.2 with El Capitan, either.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/geordanr/xwing/issues/560#issuecomment-365877053, or mute the thread https://github.com/notifications/unsubscribe-auth/AAQRt012nW3F2BCRfrppgF17DBm5idbuks5tU_7QgaJpZM4SETtK .
Does it happen in Private Browsing mode (with extensions disabled)? Maybe there's an extension that you (and your coworker) are using that's contributing to the problem.