docker
docker copied to clipboard
Added port so that the service-name of static is independent
So traefik sees the 'static' service as static-<directory>@docker and that how it is addressed. But you want to have it directory independant. There is no direct way to name/label your service , but according to this you can fix this by e.g.
labels:
- traefik.http.services.<<name_of_service>>.loadbalancer.server.port=80
So, that's what we do here. It fixes https://github.com/georchestra/docker/issues/214
Many thanks for the contribution !
Second change (about the .env) was meant to be in a different pull request. It should address https://github.com/georchestra/docker/issues/219
Bonjour François,
You're welcome. I do use gitlab but never github. So I messed up trying to make 2 different Pull Requests. I´m inclined to delete the messed-up-version, and try again. What do you think?
Merci d'avance, Huub
Yes sure, go ahead. Thanks !
hello @hpwjnijs did you have time to split the PR :)? thank you
I will close this PR, and make 2 new ones for the unrelated issues.
Hi Emilien,
Yes, I (just) did. Thanks for asking: I use gitlab a lot not github, but I somehow managed.
Cheers, Huub
Op di 14 mei 2024 om 10:58 schreef Emilien Devos @.***>:
hello @hpwjnijs https://github.com/hpwjnijs did you have time to split the PR :)? thank you
— Reply to this email directly, view it on GitHub https://github.com/georchestra/docker/pull/278#issuecomment-2109653200, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARUCKF5TYHSF5MWBGH3566DZCHG3PAVCNFSM6AAAAABFOH6B7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZGY2TGMRQGA . You are receiving this because you were mentioned.Message ID: @.***>