pywps icon indicating copy to clipboard operation
pywps copied to clipboard

Published 20 hours ago • verified publisher icon geopython

automatic tests: coveralls complains

Open cehbrecht opened this issue 7 years ago • 1 comments

Description

We have configured coveralls checks, which are not happy with us: https://coveralls.io/builds/18259291

I would see this more as a warning ... but the tests are marked as failed. Maybe we can configure it to behave more nicely.

In other projects I'm using codacy for automatic code reviews. It is not only for the statistics ... it discovers also potential bugs and security issues.

cehbrecht avatar Aug 01 '18 08:08 cehbrecht

maybe we should call for PSC meeting and discuss all the things for 4.2

jachym avatar Aug 02 '18 07:08 jachym

@cehbrecht If you're interested, I can submit a proposal relatively quickly to fix this.

Zeitsperre avatar Jul 05 '23 18:07 Zeitsperre

@cehbrecht If you're interested, I can submit a proposal relatively quickly to fix this.

@Zeitsperre sounds good. go ahead 👍

cehbrecht avatar Jul 07 '23 14:07 cehbrecht

It seems to me that the test coverage is hovering around 82%. The reporting was previously broken, but it looks as though I submitted a fix in mid-2021 that fixed that.

I've gone in today and changed the failure conditions for relative coverage reduction (-0.5% from main) and total coverage below a target (75%). I think we can safely close this issue.

Zeitsperre avatar Jul 07 '23 16:07 Zeitsperre