pywps icon indicating copy to clipboard operation
pywps copied to clipboard

Published 20 hours ago • verified publisher icon geopython

What is the purpose of WPSRequest.identifiers?

Open cehbrecht opened this issue 6 years ago • 5 comments

Description

In the WPSRequest class we have the members identifier and identifiers: https://github.com/geopython/pywps/blob/34b06f4355cce6eed7d057d17c76b001b4daf0c0/pywps/app/WPSRequest.py#L40

Looks like identifiers is a left over and a potential bug.

Steps to Reproduce

Additional Information

See also PR #330 and WPSRequest tests: https://github.com/geopython/pywps/blob/91da95ef846e4d9bce7cfd8016af467d2acfd1cb/tests/test_wpsrequest.py#L33

cehbrecht avatar Mar 26 '18 18:03 cehbrecht

The identifier member was added by PR #312 by @elemoine.

cehbrecht avatar Mar 26 '18 18:03 cehbrecht

Yep, looks fishy. self.identifier is only used in the JSON serialisation. Will take a closer look over the weekend.

ldesousa avatar Mar 27 '18 18:03 ldesousa

The identifier member was added by PR #312 by @elemoine.

That is not quite right :) WPSRequest.identifier was already there, but it was not serialized by the json property. I can provide more details if needed.

elemoine avatar Mar 27 '18 19:03 elemoine

@elemoine Some light on that code part would be nice :)

It didn't go through the code yet but I have the feeling that there should be only WPSRequest.identifier. So we need to refactor and fix the code to get rid of the extra identifierS.

cehbrecht avatar Mar 27 '18 20:03 cehbrecht

@elemoine but is it being used for something?

ldesousa avatar Mar 30 '18 15:03 ldesousa