pygeoapi icon indicating copy to clipboard operation
pygeoapi copied to clipboard

Allow using sqlalchemy > 2

Open ricardogsilva opened this issue 1 year ago • 2 comments

Now that pygeofilter supports sqlalchemy v2, and with the changes merged in #1520, it seems pygeoapi can now lift the current restriction on using sqlalchemy<2, as seen in:

https://github.com/geopython/pygeoapi/blob/6c31a8e371d10750f265357bab62b45bfa9abc8f/requirements.txt#L17

This is related to #1123, but I am not able to re-open it - feel free to close this and re-open that if appropriate.

ricardogsilva avatar May 15 '24 18:05 ricardogsilva

cc @kalxas

@ricardogsilva as discussed a couple of weeks ago, looks like SQLAlchemy is still at 1.x on jammy. We'll need to monitor accordingly and update once we have some updates from upstream.

tomkralidis avatar Jul 24 '24 20:07 tomkralidis

@tomkralidis @kalxas

Just a small nitpick, current Ubuntu LTS is now 24.04 (Noble Numbat) - but your point is still valid, the python3-sqlalchemy package is still at version 1.4.50 as per:

https://packages.ubuntu.com/noble/python3-sqlalchemy

According to sqlalchemy docs, v1.4 is compatible with version 2 and in #1520 I had already fixed existing sqlalchemy transition to v2 warnings in the codebase.

This to say that I think we are now in a position where it is possible to simply remove the sqlalchemy<v2 pin in our requirements files and things should work OK both on Ubuntu LTS, as per RFC2 and would also allow other installs to move forward with using sqlalchemy v2+.

When I find some time I will check whether everything works OK with the pin removed, most likely by trying to run the test suite inside some ubuntu:24.04 container.

ricardogsilva avatar Jul 25 '24 08:07 ricardogsilva

This Issue has been inactive for 90 days. As per RFC4, in order to manage maintenance burden, it will be automatically closed in 7 days.

github-actions[bot] avatar Oct 27 '24 03:10 github-actions[bot]

keeping this one open

kalxas avatar Oct 27 '24 09:10 kalxas