pygeoapi
pygeoapi copied to clipboard
Forks of master branch fail GitHub Actions
Description A fork of geopython/pygeoapi:master that is wanting to keep up date fails GitHub Actions because the the geopython Docker image is hard-coded into container.yml.
Some solutions could be:
- A solution for organizations that have the same organization name in GitHub and Dockerhub - which is atleast true for geopython and internetofwater, changing L67-69 would be the same behavior as already implemented for the geopython/pygeoapi repository while allowing downstream forks to fit in (more) seamlessly.
images: |
${{ github.repository }}
ghcr.io/${{ github.repository }}
- The even friendlier downstream change, which is probably overkill could be allowing the DOCKER_REPOSITORY in L18 to be a repository variable / secret.
DOCKER_REPOSITORY: ${{ vars.DOCKER_REPOSITORY || github.repository }}
Steps to Reproduce Create a fork of pygeoapi in a repository where GitHub actions are enabled. Monitor build status
Expected behavior Ability to publish pygeoapi docker images without needing to make changes to containers.yml
Screenshots/Tracebacks Failed Action Modified File Action
Environment
- OS:
- Python version:
- pygeoapi version:
Additional context Add any other context about the problem here.