geopython-workshop icon indicating copy to clipboard operation
geopython-workshop copied to clipboard

[WIP] remove shopt&alias to make it work on powershell

Open pvgenuchten opened this issue 2 years ago • 3 comments

PR to facilitate discussion on this topic

docker-compose was removed >1 year ago, i think we can assume all are migrated by now?

removing shopt and alias because it is not supported on powershell/windows

todo: update docs for windows: syntax: bash geopython-workshop-ctl.sh start|stop|url|update

  • [x] works on powershell (windows+docker desktop)
  • [x] works on ubuntu (WSL)

pvgenuchten avatar Jun 21 '23 09:06 pvgenuchten

@tomkralidis, updated docs for powershell

pvgenuchten avatar Jun 21 '23 11:06 pvgenuchten

ah, good to know people are still using docker-compose

alternative would be to duplicate the script and rename to _ps.sh

@justb4 PR updated

pvgenuchten avatar Jun 21 '23 14:06 pvgenuchten

I cannot test this, but seems useful. I wonder if the uname stuff even works. I have no idea how Powershell relates to WSL and Docker install. I have the feeling we would not need a separate Bash script with some smart 'sniffing' like the $Windows var and uname command, branching in the original script. It may be confusing even, two scripts with almost identical names.

justb4 avatar Jun 22 '23 09:06 justb4