dask-geopandas
dask-geopandas copied to clipboard
geopandas
Guidelines for contributing
Hello,
I'm loving using this project, and would love to contribute to it. The feature parity post seems like a great place to start.
And it seems like the guide for contributing to GeoPandas largely applies here as well.
Are there any substantial changes to those docs, either the list of features or the contributing guidelines? Edit: Especially curious about dependencies and testing that only apply here.
Thanks in advance, excited to learn.
Best, Alex
Thanks for your interest in contributing!
And it seems like the guide for contributing to GeoPandas largely applies here as well.
Indeed, the general GeoPandas contributing guidelines should apply here as well. I see that our CONTRIBUTING.md file still points to dask (https://github.com/geopandas/dask-geopandas/blob/main/CONTRIBUTING.md), we can maybe update that to point to geopandas.
The https://github.com/geopandas/dask-geopandas/issues/130 seems like a great place to start.
Most of the easy ones are already done by now, I think, but I added an update to that issue.
https://github.com/geopandas/dask-geopandas/issues/76 might be another good first issue. Also https://github.com/geopandas/dask-geopandas/issues/79 or https://github.com/geopandas/dask-geopandas/issues/81 should be doable but require some more advanced dask experience.
#76 looks interesting. Is this referring to the class on line 884 and NotImplementedError on line 911 of the core.py file? Sign me up for this one.
I asked about dependencies and pytest because the default imports and tests led to some package version conflicts and failed tests. I resolved the imports, but have some questions about the tests. Issue #76 seems relatively simple, so I'm not sure what's absolutely essential here, but I do want to follow the contribution guidelines (all of which make sense to me).
Running pytest on a new conda environment leads to 10 failed, 151 passed, 4 skipped, 2 xfailed, 1009 warnings in 38.38s. It's quite a lot of output; should I paste it all here?
It's quite a lot of output; should I paste it all here?
Can you open an issue for that?
It's quite a lot of output; should I paste it all here?
Can you open an issue for that?
@martinfleis here's the issue I made for this https://github.com/geopandas/dask-geopandas/issues/184