geonetwork-ui
geonetwork-ui copied to clipboard
Updates to the section 'Generate an application' in the contributing guide
Minor updates to the documentation to create a new application to specify the files to update in each step and add a required step to disable the property noPropertyAccessFromIndexSignature
.
@fgravin I noticed also about this error reported in IntelliJ for some imports
:
Error: A project without tags cannot depend on any libraries (nx-enforce-module-boundaries)
The project.json
generated has the following:
"tags": []
In the Datahub project it contains:
https://github.com/geonetwork/geonetwork-ui/blob/62b3fe2b640f31b2549d3a537774b2d961e59c19/apps/datahub/project.json#L130
Can you config if that values are both required? I will update the pull request to add this additional step.
Hi @josegar74, welcome on board ! We are busy today with Olivia in a workshop.
Error: A project without tags cannot depend on any libraries (nx-enforce-module-boundaries)
For this, we can secure the dependency direction using the tags. The rules are defined here https://github.com/geonetwork/geonetwork-ui/blob/25cd675c19d71a1daccd54de55da46b1a8606d16/.eslintrc.json#L14
type:app
should be required yes.
@josegar74 could you rebase on main please cause I have fixed the CI from fork PR (hopefully :crossed_fingers: ). Thanks