geonetwork-ui icon indicating copy to clipboard operation
geonetwork-ui copied to clipboard

ME: edit record distributions

Open LHBruneton-C2C opened this issue 1 year ago â€ĸ 6 comments

Description

This PR introduces the section on associated resources, allowing to add both download and service as distributions.

TODO: split and share components between annexes and associated resources.

Screenshots

image image

Quality Assurance Checklist

  • [X] Commit history is devoid of any merge commits and readable to facilitate reviews
  • [ ] If new logic âš™ī¸ is introduced: unit tests were added
  • [X] If new user stories 🤏 are introduced: E2E tests were added
  • [ ] If new UI components đŸ•šī¸ are introduced: corresponding stories in Storybook were created
  • [ ] If breaking changes đŸĒš are introduced: add the breaking change label
  • [ ] If bugs 🐞 are fixed: add the backport <release branch> label
  • [ ] The documentation website 📚 has received the love it deserves

LHBruneton-C2C avatar Sep 23 '24 13:09 LHBruneton-C2C

Affected libs: feature-editor, ui-inputs, feature-dataviz, feature-record, feature-router, feature-search, feature-map, ui-elements, feature-notifications, feature-catalog, ui-catalog, ui-search, ui-layout, Affected apps: metadata-editor, datafeeder, demo, metadata-converter, datahub, webcomponents, search, map-viewer,

  • [ ] 🚀 Build and deploy storybook and demo on GitHub Pages
  • [ ] đŸ“Ļ Build and push affected docker images

github-actions[bot] avatar Sep 23 '24 13:09 github-actions[bot]

📷 Screenshots are here!

github-actions[bot] avatar Sep 23 '24 14:09 github-actions[bot]

Did a quick test and found this:

  • When trying to upload a file as a distribution, this error appears in the console and nothing happens: image; same for the "attached resources" field below actually

  • When clicking on the main block, the upload file dialog doesn't open

Otherwise looks good! thanks!

jahow avatar Sep 26 '24 13:09 jahow

Just chiming in - "OGC API" title is misleading because there are so many OGC APIs (OGC API Maps, Features, Tiles...) Have a look at https://ogcapi.ogc.org/#standards

fvanderbiest avatar Sep 26 '24 13:09 fvanderbiest

Just chiming in - "OGC API" title is misleading because there are so many OGC APIs (OGC API Maps, Features, Tiles...) Have a look at https://ogcapi.ogc.org/#standards

On the other hand it makes sense because an OGC API endpoint can provide many different information at the same place I think

jahow avatar Sep 26 '24 13:09 jahow

Coverage Status

coverage: 81.027% (-3.9%) from 84.949% when pulling 177e6ab86e81861f52a5d898350650c342798918 on ME/record-field-distributions into be9519760a3db6038a0730e203c8178aa5c7a1af on main.

coveralls avatar Sep 26 '24 14:09 coveralls