core-geonetwork icon indicating copy to clipboard operation
core-geonetwork copied to clipboard

Published 20 hours ago • verified publisher icon geonetwork

formatter: remove alert message if 201 on upload

Open fgravin opened this issue 2 years ago • 2 comments

Fix https://github.com/geonetwork/core-geonetwork/issues/6449

fgravin avatar Jul 06 '22 14:07 fgravin

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jul 06 '22 14:07 sonarqubecloud[bot]

The change should be fine, but it's unclear to me why a response code ' 201` is triggering the fail handler.

josegar74 avatar Jul 14 '22 13:07 josegar74

Thanks @josegar74 It's managed by the dependency which is quite old and seems to test for a 200. I tried to dig into the code to see if I can pass options or handle better this case but it seems I can't so my proposition is the safest fix IMO.

fgravin avatar Aug 30 '22 09:08 fgravin