core-geonetwork icon indicating copy to clipboard operation
core-geonetwork copied to clipboard

Published 20 hours ago • verified publisher icon geonetwork

Metadata inserted through CSW-T are not fully public (no download/interactive map/featured)

Open eblondel opened this issue 5 years ago • 8 comments

Issue Description

Metadata inserted through CSW-T are not fully public, although the CSW-T configuration Inserted metadata is public is checked (When a transation insert a new record via the CSW-T protocol, automatically publish the record to all users). The metadata can be browsed anonymously BUT it doesn't handle any link to WMS or link to download because these privileges are not enabled by default.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Geonetwork config, and enable "Inserted metadata is public", save config.
  2. Insert a metadata (that includes some WMS and/or download links) using CSW-T protocol.
  3. Check the metadata privileges as logged user. (The output should be "Publish", we miss "Interactive Map" and "Download" that remain unchecked)
  4. See XML metadata as logged user (WMS/download links appear)
  5. Logout and see XML metadata as anonymous (WMS/download links are not available)

Expected behavior

Metadata inserted through CSW-T, with the CSW-T "inserted metadata is public" enabled, should be fully publicly available (published) including with "Interactive Map" & "Download" Geonetwork privileges.

Desktop

  • Browser: Chrome
  • GeoNetwork Versions tested: 3.8.1 (installed from docker official image), legacy versions tested as well using other instances: 3.0.4, 3.2.2

eblondel avatar Oct 30 '19 09:10 eblondel

@fxprunayre @josegar74 any blocker to merge the above code, and have it released in Geonetwork?

eblondel avatar Jul 27 '21 14:07 eblondel

@fxprunayre @josegar74 any blocker to merge the above code, and have it released in Geonetwork?

Looks like it is part of 3.12 series so we can close no? https://github.com/geonetwork/core-geonetwork/blob/3.12.x/csw-server/src/main/java/org/fao/geonet/component/csw/Transaction.java#L284-L290

fxprunayre avatar Jul 27 '21 15:07 fxprunayre

Odd that the changes are missing in the main branch?

https://github.com/geonetwork/core-geonetwork/blob/eacc1d47d5ba225df777add0caf804889e8fd252/csw-server/src/main/java/org/fao/geonet/component/csw/Transaction.java#L287-L289

Shouldn't the changed be put into main so that it is part of the 4.x release?

ianwallen avatar Jul 27 '21 16:07 ianwallen

@josegar74 wants to merge 3.12 in main but I think still some work required on this.

fxprunayre avatar Jul 27 '21 16:07 fxprunayre

@fxprunayre for now we're cherry-picking specific fixes from 3.12.x to main, not doing a full merge.

But the code seem fine now in main, no?

https://github.com/geonetwork/core-geonetwork/blob/51d66613ac579b2de090f5bad4990e183a68aea8/csw-server/src/main/java/org/fao/geonet/component/csw/Transaction.java#L287-L291

josegar74 avatar Aug 16 '21 10:08 josegar74

But the code seem fine now in main, no?

Yep done in https://github.com/geonetwork/core-geonetwork/pull/5882

fxprunayre avatar Aug 16 '21 11:08 fxprunayre

hello @fxprunayre is this solved?

eblondel avatar Nov 29 '21 15:11 eblondel

@fxprunayre @josegar74 @juanluisrp I see this jumping from one milestone to another :-) but i don't really know if this has been integrated, and if yes since which GN version? I understand according to @fxprunayre that it has been merged into https://github.com/geonetwork/core-geonetwork/pull/5882 Thanks in advance

eblondel avatar Jul 05 '22 07:07 eblondel

Ok, inspecting tags and #5882, this feature is available since 4.0.6 I'm closing the ticket. Thanks @fxprunayre for handling this in #5882

eblondel avatar Jan 17 '23 21:01 eblondel