FBReaderJ icon indicating copy to clipboard operation
FBReaderJ copied to clipboard

Adding RTL language support

Open khajavi opened this issue 13 years ago • 7 comments

Hi, I want to contribute this project to fix RTL rendering problem of FBReader in Android. Can you direct me which class that need to be enhanced?

khajavi avatar Jan 28 '12 15:01 khajavi

geometer, this lad is asking for your help :)

soshial avatar May 02 '12 13:05 soshial

I have patched RTL support into FBReader - it's slightly primitive (the entire book is typeset in one direction, chosen by a static comparison of the language tag to "he" or "ar") but it appears to work OK: https://github.com/nolaviz/FBReaderJ.git

nolaviz avatar Sep 15 '12 19:09 nolaviz

Heh, does it work with bi-directional texts?

geometer avatar Sep 16 '12 14:09 geometer

 Heh, does it work with bi-directional texts?

No :| It's the very barest minimum - the book language determines the direction for all text, period. No handling of , , or BIDI marks. But it's sufficient for prose... Which is a start.

nolaviz avatar Sep 16 '12 15:09 nolaviz

Hi @nolaviz I'm trying to fix RTL problem in Fbreader. Since last commit to fork version was from 3 years ago i'm not inclined to use it. So can you tell me which files did you change so i can only edit those files on the last version or maybe copy those files from fork version? I really appropriate any help

alz-ahm avatar Apr 12 '15 06:04 alz-ahm

body p { margin-bottom: 0cm; margin-top: 0pt; } 


On 04/12/2015 09:35 AM, alirezaahmadi69
  wrote:


  Hi @nolaviz I'm trying to fix RTL
    problem in Fbreader. Since last commit to fork version was from
    3 years ago i'm not inclined to use it. So can you tell me which
    files did you change so can edit those files only on the last
    version or maybe copy those files from fork version?



The only commits I had made in FBReaderJ for (primitive) RTL
  support were ff50c8b
  and 8213c82.
  If you can merge these into the latest FBReaderJ (and fix any
  conflicts) you'll be in the same state.


Regards
-az

nolaviz avatar Apr 14 '15 18:04 nolaviz

#474

herotux avatar Feb 21 '18 16:02 herotux