ObjectListView icon indicating copy to clipboard operation
ObjectListView copied to clipboard

FastObjectListView - MoveObjects() attempts invalid insertion with index -1

Open PyroGenesis opened this issue 3 years ago • 0 comments
trafficstars

When I used MoveObjects() with an index of 0 with a collection of objects that includes the first object (at index 0), I get an IndexOutOfRangeException because it will try to insert objects at index -1.

I narrowed it down to this block of code in MoveObjects(): https://github.com/geomatics-io/ObjectListView/blob/8a10cbd934adca7991b2447298a9f22c67368a70/ObjectListView/FastObjectListView.cs#L123-L128

Since, the first object (at index 0) will satisfy the if condition, the index will be decreased from 0 to -1. Should this condition be changed to if (i >= 0 && i < index) instead?

PyroGenesis avatar Apr 20 '22 16:04 PyroGenesis