leaflet-geoman icon indicating copy to clipboard operation
leaflet-geoman copied to clipboard

Some icons broken after updating from 2.13.0 -> 2.16.0

Open viktorsmari opened this issue 1 year ago β€’ 3 comments
trafficstars

image

Here we have some icons (not all) broken after this update.

When inspecting we see some don't work image

Some work image

When I open up a broken icon in a new tab it actually works: image

Could the %0A be a part of the issue? image

Any ideas how I could debug further?

viktorsmari avatar Aug 22 '24 16:08 viktorsmari

If I use a CDN it works, so I cannot reproduce on JSFiddle.

I am using Ruby on Rails and esbuild.

package.json:

  "dependencies": {
    "@geoman-io/leaflet-geoman-free": "^2.16.0",

app/assets/stylesheets/application.bootstrap.scss:

@import 'leaflet.markercluster/dist/MarkerCluster.Default';
@import 'flatpickr/dist/flatpickr';
@import '@geoman-io/leaflet-geoman-free/dist/leaflet-geoman';

This works fine in earlier versions:

  • 2.13 works
  • 2.15 works
  • 2.16 does not work
  • 2.17 does not work

viktorsmari avatar Aug 23 '24 11:08 viktorsmari

Hi, with the 2.16.0 Version we accidentally made a breaking change. The build process was updated and sometimes causes problems with older builders. We suggest to try to update your builder.

See: https://github.com/geoman-io/leaflet-geoman/releases/tag/v2.16.0

Falke-Design avatar Aug 28 '24 17:08 Falke-Design

Thanks @Falke-Design I am using version 0.23.1 of esbuild - but still having this issue. What else should I upgrade?

viktorsmari avatar Aug 29 '24 13:08 viktorsmari

After some digging I wasn't able to reproduce it

Falke-Design avatar Nov 24 '24 20:11 Falke-Design