mergesorts icon indicating copy to clipboard operation
mergesorts copied to clipboard

added MATLAB implementation, updated run.sh

Open Imaniac230 opened this issue 4 years ago • 14 comments

Not sure if useful but adding a version in the MATLAB language. There might be a cleaner way to display the matlab output in the terminal. Most of the delay is by starting up the matlab environment.

Imaniac230 avatar Jul 20 '20 13:07 Imaniac230

Can you make it run in CI?

geohot avatar Jul 20 '20 14:07 geohot

It should work, but I'm not sure how it handles the licenses. I'll see what I can do with it.

Imaniac230 avatar Jul 20 '20 18:07 Imaniac230

Octave?

geohot avatar Jul 20 '20 19:07 geohot

Yes, that will probably be the easiest and safest solution. Code runs with both.

Imaniac230 avatar Jul 20 '20 23:07 Imaniac230

Hmm, m is used by objc.

geohot avatar Jul 21 '20 15:07 geohot

Wow, I did not expect that to happen. I'm not sure what to do at this point then. Matlab does not work with any other extension, I don't know how it is with objc.

Imaniac230 avatar Jul 21 '20 15:07 Imaniac230

@Imaniac230 @geohot .mm can be used for objc file but technically it ll be objc++.

gshanbhag525 avatar Jul 21 '20 18:07 gshanbhag525

Tried running objc with *.mm, problem is it currently doesn't compile in CI either way.

Imaniac230 avatar Jul 22 '20 21:07 Imaniac230

@Imaniac230 Maybe rename your file as mergesortMatlab.m and it ll go through CI

gshanbhag525 avatar Jul 23 '20 19:07 gshanbhag525

@gshanbhag525 the matlab version works fine in CI but the objc one spits out an error. I don't know objc so I couldn't make that one compile.

Imaniac230 avatar Jul 23 '20 20:07 Imaniac230

So since there's no way to have both versions at the same time other than changing one of the files anyway I have renamed mine. Please check the compilation of objc in CI though, it doesn't compile. May open up an issue?

Imaniac230 avatar Jul 24 '20 14:07 Imaniac230

@Imaniac230 If you have a mac, there should not be an issue while compiling.

gshanbhag525 avatar Jul 24 '20 16:07 gshanbhag525

@gshanbhag525 hmm that might be it. I'm talking about the integrated github CI check. The workflow is set to ubuntu-20.04. Or maybe I am missing something?

Imaniac230 avatar Jul 24 '20 16:07 Imaniac230

@geohot why no merge on this one?

Imaniac230 avatar Jul 26 '20 18:07 Imaniac230