George Hotz

Results 1073 comments of George Hotz

Tests failing, going to close.

Bounty locked. So this is enough code I think it should be not in `ops_hip.py` It should almost be a separate package. Like `pip install pyhip` or `pyrocm`

Ideally it's refactored so it shares as many codepaths in tinygrad as possible. Currently, it's a different Buffer, Codegen, and Runtime!

Awesome stuff! I haven't had much time to work on this, though I've come around somewhat on VLIW and systolic arrays. Efficiency has a lot to do with data movement...

https://mlir.llvm.org/docs/PatternRewriter/

It's a little annoying because there's not a way to do the pattern flexibly. Could do a class like MLIR ```python # (x+c0)+c1 -> x + (c0+c1) patterns: List[Tuple[Dict, Callable[[UOp],...

Can we use this DSL? Does MLIR usually use it? https://mlir.llvm.org/docs/PDLL/ It looks complex. Maybe too complex.

A bit better, the `set(` supports any order. ```python patterns: List[Tuple[Dict, Callable[[UOp], UOp]]] = [ # (x+c0)+c1 -> x + (c0+c1) ({"uop": UOps.ALU, "arg": BinaryOps.ADD, "vin": set({"__name__": "c0", "uop": UOps.CONST},...

This is a feature that will sell me on trunk QIRA for CTFs

And sadly, the python plugin doesn't work well, add_bpt isn't good from the other thread