wildcard icon indicating copy to clipboard operation
wildcard copied to clipboard

Ajax filter fixes

Open karlicoss opened this issue 4 years ago • 0 comments

Tagging @TylerMillis as the original author.

  • first commit: adds main_frame and xmlhttprequest scopes. Without it, some pages (e.g. https://hn.algolia.com) aren't loading at all. I haven't managed to figure out why exactly, but the documentation suggest limiting the scope anyway, so perhaps it makes sense.

  • second commit -- mainly added finally clause, so filters don't leak in case of exception, but also didn some minor cleanup, hope you don't mind!

Also wondering, what's the reason to use "blocking"? It works without it (at least the uber eats page), and the documentation says it's used for cancels or redirects (makes sense).

P.S. oh, also, I guess urls: ["<all_urls>"] is a bit too broad? I guess this would be good to fix later.

karlicoss avatar May 08 '20 15:05 karlicoss