aspect icon indicating copy to clipboard operation
aspect copied to clipboard

Adds an updated version of the Jupyter notebook tutorial for the onse…

Open ljhwang opened this issue 1 year ago • 8 comments

Back at the 2017 hack in Georgia, the original onset of convection tutorials were converted to Jupyter notebooks.

This adds an updated version of the notebook to the cookbook directory that the tutorial is related to.

Updates include:

  • modifications to the prm files. Note that between versions the structure changed.
  • modifications to the Nusselt-Rayleigh number relationship exercise. Note with the substantial improvements to the solver, the results changed. I have left the previous numbers in for historic reasons and arbitrarily reset the end times. Feel free to suggest a different set of parameters.
  • corrected a bug in plotting the Nusselt-Rayleigh number plot. Verification by the reviewer that this is now correct is warranted.

The updated version is designed to work using the ASPECT Jupyterlab environment on geodynamics.org: https://geodynamics.org/resources/aspectnotebook

The instructions to run in the old Docker container and the old parameter files are retained. This could be removed if a new docker container is made or this is confusing.

ljhwang avatar Dec 19 '23 19:12 ljhwang

Can you please remove all the checkpoint files you accidentally added?

tjhei avatar Dec 27 '23 02:12 tjhei

@tjhei Thanks for the catch on the hidden files. Hopefully this is clean now.

ljhwang avatar Dec 27 '23 17:12 ljhwang

You'll have to merge the two commits (squash or fix-up) to ensure these large files are not in one commit and then removed in the next, leaving them as large (but unnecessary) additions to the repository.

bangerth avatar Jan 09 '24 05:01 bangerth

@bangerth. Both of your comments have been addressed and this should be ready to be merged. Once merged, I will remove the old prm files and update the README to be consistent. ty.

ljhwang avatar Jan 19 '24 18:01 ljhwang

I removed the checkpoint files.

gassmoeller avatar Jan 26 '24 19:01 gassmoeller

It fails the indentation check with these diffs:

diff --git a/cookbooks/convection-box/tutorial-onset-of-convection/README.md b/cookbooks/convection-box/tutorial-onset-of-convection/README.md
index a1d0535..1668690 100644
--- a/cookbooks/convection-box/tutorial-onset-of-convection/README.md
+++ b/cookbooks/convection-box/tutorial-onset-of-convection/README.md
@@ -29,11 +29,11 @@ If you run in your local JupyterLab environment, note the following dependencies
  * ipympl
  * scipy
  * glob
- 
- 
- 
+
+
+
 ## Packages install
- 
+
 The heat flux slider requires the installation of two additional packages.
 
 **Adding Jupyter widgets**
@@ -43,5 +43,3 @@ You should have added this in Step 3 above:
 
 **Installing tables**
 > conda install tables
- 
- 
\ No newline at end of file
diff --git a/cookbooks/convection-box/tutorial-onset-of-convection/model_input/tutorial.prm b/cookbooks/convection-box/tutorial-onset-of-convection/model_input/tutorial.prm
index d6f0ff2..3686151 100644
--- a/cookbooks/convection-box/tutorial-onset-of-convection/model_input/tutorial.prm
+++ b/cookbooks/convection-box/tutorial-onset-of-convection/model_input/tutorial.prm
@@ -[14](https://github.com/geodynamics/aspect/actions/runs/7674802326/job/20920049230?pr=5533#step:6:15)7,4 +147,3 @@ subsection Postprocess
     set Data output format = vtu
   end
 end
-

bangerth avatar Mar 09 '24 01:03 bangerth

The other failures seem to come from the fact that the root of the branch is at a point in time where we had the GMG failures.

bangerth avatar Mar 09 '24 01:03 bangerth

I indented, rebased and fixed a number of remaining typos, this should be good to go @ljhwang.

gassmoeller avatar Mar 15 '24 20:03 gassmoeller