aspect icon indicating copy to clipboard operation
aspect copied to clipboard

Fastscape c++ coupling [WIP]

Open Minerallo opened this issue 2 years ago • 0 comments

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

The existing coupling between ASPECT and FastScape, developed by Derek Neuharth and Anne Glerum, utilizes the Fortran version of FastScape. However, this Fortran version is no longer being actively developed. I want to couple ASPECT with the actively developed C++ version of FastScape (Fastscapelib), which will incorporate an unstructured grid and be parallelized. This will make ASPECT - FastScape working with large scale spherical models. I have integrated the Fastscape C++ library to the contrib folder and added the paths to the Cmakelist. I re-use some of the fastscape fortran interface from PR #4396 to develop the initial FastScapecc (.cc, .h) which call the Stream Power law erosion function of fastscapelib.

I added a test case repository in tests repository with a output_screen but it is not working yet. It runs for few timesteps and crashes sending malloc errors.

Before your first pull request:

  • [x] I have read the guidelines in our CONTRIBUTING.md document.

For all pull requests:

  • [x] I have followed the instructions for indenting my code.

For new features/models or changes of existing features:

  • [x] I have tested my new feature locally to ensure it is correct.
  • [x] I have created a testcase for the new feature/benchmark in the tests/ directory.
  • [ ] I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

Minerallo avatar Jul 14 '23 18:07 Minerallo