aspect icon indicating copy to clipboard operation
aspect copied to clipboard

Published 20 hours ago • verified publisher icon geodynamics

Add cpo property Bingham average

Open MFraters opened this issue 2 years ago • 1 comments

Adds a particle property plugin to compute the Bingham average for the CPO particle properties.

This implementation is based on https://github.com/geodynamics/aspect/pull/4978, so this should not be merged until that one is. It is ready for review though.

(point 4 in https://github.com/geodynamics/aspect/issues/3885)

MFraters avatar Oct 11 '22 14:10 MFraters

Now that #4978 is merged, I have rebased this pull request to the current main branch. It should now be fully ready.

MFraters avatar Oct 12 '22 13:10 MFraters

@gassmoeller Thanks for the review. I have addressed your comments and replaced the random draw function with a new utilities one (see #5094) based on your suggestion.

MFraters avatar Mar 12 '23 19:03 MFraters

Looks good, just some minor comments left. I guess we need https://github.com/geodynamics/aspect/pull/4979 before we can test this?

Thanks, I have addressed your comments. It probably is possible to design individual tests by looking the particle output directly, but I would like to wait with that until #4979, #4987 and point 8 in #3885 are merged, since it will be a lot easier to check if the results are actually what is expected.

MFraters avatar Mar 14 '23 16:03 MFraters