aspect icon indicating copy to clipboard operation
aspect copied to clipboard

Add CPO main postprocessor

Open MFraters opened this issue 2 years ago • 1 comments

This pull request adds a post-processor to output relevant CPO information.

This implementation is based on #4978, so this should not be merged until that one is. It is ready for review though.

(point 3 in #3885)

MFraters avatar Oct 11 '22 11:10 MFraters

Now that #4978 is merged, I have rebased this pull request to the current main branch. It should now be fully ready.

MFraters avatar Oct 12 '22 13:10 MFraters

Just for my understanding: Is this essentially a copy of the particle postprocessor, except it does only process the CPO particle properties in a special way before outputting these postprocessed quantities into files that are separate from the normal particle output files?

Yes, that is correct. It allows for a flexible way to output the data in the way you want, both raw (which can be useful to look directly at the data) and volume weighted (which you need for useful pole figures). And these files can than be for example used directly to make these pole figures with this code: https://github.com/mfraters/cpo_analyzer.

MFraters avatar Oct 20 '22 05:10 MFraters

Thanks for the review! I have addressed your initial comments :)

MFraters avatar Oct 20 '22 22:10 MFraters

I have updated this pull request after #5094 got merged. See comment in #4980 about tests

MFraters avatar Mar 14 '23 16:03 MFraters

Thanks for the review. I have adressed all your comments and it i ready for another review :)

MFraters avatar Jul 08 '23 23:07 MFraters

Thanks for the review. I have addressed your comments.

MFraters avatar Jul 09 '23 19:07 MFraters

Thanks, I have addressed your comments.

MFraters avatar Jul 10 '23 00:07 MFraters

Fixed the changlog entry

MFraters avatar Jul 10 '23 02:07 MFraters