aspect icon indicating copy to clipboard operation
aspect copied to clipboard

Published 20 hours ago • verified publisher icon geodynamics

(WIP) GMG: use deal.II compute_diagonal()

Open tjhei opened this issue 2 years ago • 5 comments

Use compute_diagonal() inside deal.II instead of our own version. This needs to be tested more, but we would be able to get rid of a lot of code this way.

I am opening this to be able to run the tests.

FYI: @zjiaqi2018

tjhei avatar May 23 '22 15:05 tjhei

Why are the test outputs changing? Is it due to different values on the constrained entries or is this just a numerical artifact?

peterrum avatar Jun 06 '22 12:06 peterrum

I am not sure, but this could be a bug. It seems like it only makes a difference if the Newton solver is used.

tjhei avatar Jun 06 '22 16:06 tjhei

@zjiaqi2018 Can you take a look and review this PR?

tjhei avatar Jun 06 '22 18:06 tjhei

@zjiaqi2018 Can you take a look and review this PR?

Sure

zjiaqi2018 avatar Jun 06 '22 18:06 zjiaqi2018

I am not sure, but this could be a bug. It seems like it only makes a difference if the Newton solver is used.

Strange, ABlock doesn't even have Newton derivatives.

zjiaqi2018 avatar Jun 07 '22 02:06 zjiaqi2018

superseded by #5060 #5061 #5062

tjhei avatar Feb 10 '23 20:02 tjhei