aspect icon indicating copy to clipboard operation
aspect copied to clipboard

Add plate cooling to adiabatic initial temperature plugin

Open danieldouglas92 opened this issue 3 years ago • 1 comments

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

Describe what you did in this PR and why you did it.

Before your first pull request:

  • [ ] I have read the guidelines in our CONTRIBUTING.md document.

For all pull requests:

  • [ ] I have followed the instructions for indenting my code.

For new features/models or changes of existing features:

  • [ ] I have tested my new feature locally to ensure it is correct.
  • [ ] I have created a testcase for the new feature/benchmark in the tests/ directory.
  • [ ] I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

danieldouglas92 avatar Jul 12 '21 20:07 danieldouglas92

I addressed most of the comments, but the test case that I've written does not have a varying temperature. The temperature everywhere in the model is equal to the adiabatic surface temperature set in the input file (for both the half space and plate cooling model, and for ages read in from an ASCII file or set in the input file)

danieldouglas92 avatar Jul 15 '21 20:07 danieldouglas92