geode icon indicating copy to clipboard operation
geode copied to clipboard

fixed missing typename keyword

Open Mikhail101010 opened this issue 2 months ago • 8 comments

Fixed missing typename keyword necessary for building mods on Mac OS.

Mikhail101010 avatar Oct 19 '25 05:10 Mikhail101010

idk i kinda doubt it

matcool avatar Oct 19 '25 05:10 matcool

Yeah, I can build mods just fine.

hiimjasmine00 avatar Oct 19 '25 09:10 hiimjasmine00

Yeah, I can build mods just fine.

Which version of clang do you use? Because every time i tried to build the mod using geode build it gave me this error:

In file included from <built-in>:1:
In file included from /Users/mikhail/MyMod/build/CMakeFiles/MyMod.dir/cmake_pch_arm64.hxx:6:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/Geode.hpp:3:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/Bindings.hpp:12:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/utils/addresser.hpp:11:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/cocos/extensions/cocos-ext.h:7:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/cocos/extensions/GUI/CCControlExtension/CCControlExtensions.h:28:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/cocos/extensions/GUI/CCControlExtension/CCScale9Sprite.h:31:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/cocos/extensions/GUI/CCControlExtension/../../../include/cocos2d.h:46:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/cocos/include/../actions/CCActionInterval.h:30:
/Users/Shared/Geode/sdk/loader/include/Geode/cocos/include/../actions/../base_nodes/CCNode.h:652:28: error: missing 'typename' prior to dependent type name 'geode::CCArrayExtCheck<T, PleaseDontChangeMe>::type'
        using CCArrayExt = geode::CCArrayExtCheck<T, PleaseDontChangeMe>::type;
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from <built-in>:1:
In file included from /Users/mikhail/MyMod/build/CMakeFiles/MyMod.dir/cmake_pch_arm64.hxx:6:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/Geode.hpp:4:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/Loader.hpp:6:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/loader/Mod.hpp:12:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/loader/Setting.hpp:3:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/loader/SettingV3.hpp:8:
In file included from /Users/Shared/Geode/sdk/loader/include/Geode/loader/../utils/file.hpp:6:
/Users/Shared/Geode/sdk/loader/include/Geode/utils/Task.hpp:1030:30: error: missing 'typename' prior to dependent type name 'MyTask::Type'
            void return_base(MyTask::Type value) {
                             ^~~~~~~~~~~~
/Users/Shared/Geode/sdk/loader/include/Geode/utils/Task.hpp:1097:13: error: missing 'typename' prior to dependent type name 'Task<T, P>::Type'
            Task<T, P>::Type await_resume() {
            ^~~~~~~~~~~~~~~~
3 errors generated.

Mikhail101010 avatar Oct 19 '25 15:10 Mikhail101010

what version of clang/macos do you use? github actions doesnt have this issue either.

matcool avatar Oct 19 '25 15:10 matcool

I use MacOS 13.0.1

My clang version:

Apple clang version 14.0.3 (clang-1403.0.22.14.1)
Target: arm64-apple-darwin22.1.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Mikhail101010 avatar Oct 19 '25 15:10 Mikhail101010

try upgrading your clang version

Erymanthus:~ apple-macbook$ clang --version
Apple clang version 17.0.0 (clang-1700.3.19.1)
Target: x86_64-apple-darwin25.0.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

RayDeeUx avatar Nov 04 '25 18:11 RayDeeUx

That requires an Xcode update, which MIGHT require a macOS update as well

hiimjasmine00 avatar Nov 04 '25 18:11 hiimjasmine00

cant you install llvm clang from brew? even the docs mention this

matcool avatar Nov 04 '25 18:11 matcool