Geocoder icon indicating copy to clipboard operation
Geocoder copied to clipboard

Added 'short_name' field for street name for google maps

Open Tiraniel opened this issue 7 years ago • 8 comments

Added short street name field for Google Maps provider

Tiraniel avatar Dec 19 '18 10:12 Tiraniel

Hello @Tiraniel

Thanks a lot for your contribution ! Could you make sure the tests succeed by adding the .cached_response for your new testStreetShortNameWithRealAddress() test ?

Thanks.

jbelien avatar Dec 19 '18 11:12 jbelien

Hello @jbelien

Thanks for response. This is my first contribution attempt. Sure I'll make changes.

Tiraniel avatar Dec 20 '18 04:12 Tiraniel

Thanks a lot @Tiraniel ! Looking much better ! 👍

I realize that every component has a long_name and a short_name. Why limit your PR to route only ? Could you extend it to every component ?

PS: The test still fails but I'm having a look at it, don't worry about that.

jbelien avatar Dec 26 '18 09:12 jbelien

Sure. I can extend components with sort_name. Thanks for review!

Tiraniel avatar Dec 26 '18 10:12 Tiraniel

Hello @Tiraniel , any chance you could work on this ?

PS: It will need a rebase to apply our last updates.

jbelien avatar Jan 21 '19 15:01 jbelien

Hello @jbelien . Sorry, just back from long vacation. Will finish this week.

Tiraniel avatar Jan 24 '19 06:01 Tiraniel

Can pick this one up if help is required :smile:

atymic avatar Jun 05 '19 00:06 atymic

@Tiraniel Any chance you could finish this PR ? Thanks.

jbelien avatar May 27 '20 06:05 jbelien