Geocoder icon indicating copy to clipboard operation
Geocoder copied to clipboard

Gs7 updateUpdate Here Geocode and Reverse Geocode Provider to GS7 (v7)

Open SCatrinh opened this issue 1 year ago • 2 comments

Updates Here provider to support GS7 under the 0.8.0 version tag. Details in linked issue

Closes #1230

SCatrinh avatar Jul 03 '24 16:07 SCatrinh

Synced with master @jbelien , thanks again for reviewing

patrickghidossi avatar Jan 15 '25 18:01 patrickghidossi

Hello @patrickghidossi ,

Thanks for your contribution.

I had a first (quick) look to the changes made. This looks more like a breaking change (and so a new major version) than just an update (and minor version).

Looking at some documentation, I've found this:

GS7 introduces a new way to authenticate the application. Instead of using the Appid/Appcode combination, you must use the API Key or OAuth 2.0 token authentication methods for improved security. App code credentials are now on the verge of deprecation as they are the least secure of the authentication credential types. I still see some reference to AppId in your code, is it stil supported?

I see that you changed some tests, the goal of those tests is to make sure we don't introduce breaking changes ; please keep the tests as they are, only adapt what needs to be adapted. If there are new features in v7, feel free to add extra tests.

Before I'll review the code, could you already do the following:

  • Prepare version 1.0.0 instead of 0.8.0
  • Rebase to our master branch
  • Make sure all PHPStan checks are passing
  • Keep tests as they are

Thanks!

jbelien avatar Feb 16 '25 08:02 jbelien