geoarrow-rs
geoarrow-rs copied to clipboard
Use stable Rust for cargo fmt checks in CI
I assume this was set before the 2024 edition dropped, which cleaned up a lot of gripes some people had with rustfmt. Would you be OK with updating this to use the stable channel instead?
I really like import sorting, which isn't stable: https://rust-lang.github.io/rustfmt/?version=v1.8.0&search=#group_imports
Fair enough ;) In that case:
- Should we also add the nightly formatter requirement to the contributor docs?
- Does it require a specific nightly version? Or can we just tell contributors to add
+nightly?
- Should we also add the nightly formatter requirement to the contributor docs?
Yes! We should! Would you like to make a PR for that?
- Does it require a specific nightly version? Or can we just tell contributors to add
+nightly?
I don't think so. I think any nightly is fine.
But I don't want spurious errors in CI so in CI I have it pinned to a specific date. But I'm fine with periodically updating that nightly date.