geoarrow-js icon indicating copy to clipboard operation
geoarrow-js copied to clipboard

Update README.md

Open rajsite opened this issue 2 years ago • 2 comments

The example snippet in the README shows the @geoarrow/geoarrow-js/worker entrypoint but the rollup and src/index.ts config show a worker named import instead. This updates the README to reflect that difference.

rajsite avatar Feb 21 '24 01:02 rajsite

@kylebarron This PR fixes the imports of the README example, but it looks like the README example still has other issues, see: https://github.com/geoarrow/geoarrow-js/issues/25

rajsite avatar Feb 21 '24 01:02 rajsite

I'm not really sure which is the better import; JS bundling confuses me.

As for the example, as a quick fix to have a working example, we can switch to

const originalData = arrow.makeVector(new Int32Array([1, 2, 3])).data[0];

kylebarron avatar Feb 21 '24 14:02 kylebarron

Haven't had a chance to take another look so will close for now. Thanks for taking a look!

rajsite avatar Aug 14 '24 03:08 rajsite