deck.gl-layers icon indicating copy to clipboard operation
deck.gl-layers copied to clipboard

Deckgl ver9

Open deanm0000 opened this issue 1 year ago • 6 comments

I got an error about multiple versions of deck.gl. They're up to v9.

deanm0000 avatar Mar 27 '24 22:03 deanm0000

Yes it's in progress. https://github.com/geoarrow/deck.gl-layers/pull/112

kylebarron avatar Mar 27 '24 22:03 kylebarron

I'd be keen to help with this if I can.

I've got a build based on your PR with everything on the latest 9.0.12 of deck.gl, and the examples for which data is available (point, poly and multi-poly) all seem to work fine. Happy to go off and test the other examples with applicable data that I can find/generate.

Is this just a matter of bump and test the examples or is there a little more to it?

atmorling avatar May 02 '24 11:05 atmorling

Indeed, it really is just a matter of bumping the versions and testing the examples. I haven't looked at the full change list for deck.gl v9 and if there's any change to the binary interface that I should watch out for. But from my exploration in https://github.com/geoarrow/deck.gl-layers/pull/112 I didn't seem to hit any blockers.

A PR would be great!

One other thing to note, I've had some initial discussion with the deck.gl team about starting the process of upstreaming this into deck.gl. They suggested first moving work to the visgl/deck.gl-community repo to incubate the project and later possibly upstream it into deck.gl proper. See https://github.com/visgl/deck.gl-community/pull/67

I haven't had the time yet to look at the fork made there. I've been more focused on the Python side in Lonboard. The build system in deck.gl-community is quite different I think. It's probably ok to make PRs here with the expectation of later making PRs to update "upstream" from here. But open to thoughts/feedback

kylebarron avatar May 03 '24 15:05 kylebarron

Cool! It seems like they've already bumped everything upstream so I guess that's covered.

I expect there isn't a need to bring additions they've made back into this repo, but let me know what you think.

atmorling avatar May 06 '24 12:05 atmorling

I don't know whether it's worth synchronizing the repos.

I think primarily it'll just be annoying to follow the deck.gl-community release schedule, because so far I've published a new version here whenever I wanted to use something in lonboard. But maybe we can publish new upstream alpha versions as well regularly.

kylebarron avatar May 10 '24 16:05 kylebarron

In that case I'll submit a PR to this repo for the build I linked above with deck.gl bumped.

atmorling avatar May 15 '24 07:05 atmorling

Closed by https://github.com/geoarrow/deck.gl-layers/pull/112

kylebarron avatar May 20 '24 20:05 kylebarron

Can you please release the new deckgl 9 to npm ? @kylebarron

yharby avatar May 23 '24 19:05 yharby

I published @geoarrow/[email protected] with the latest main

kylebarron avatar Jun 02 '24 12:06 kylebarron