Georgios Andrianakis

Results 773 comments of Georgios Andrianakis

> Internal classes (which have to be public because Quarkus extension depends on them) are moved into internal packages. @geoand I hope it is not a big deal. Not a...

> An alternative approach could be to annotate each API object with the relevant annotations This would be the safest option. Another option would be for frameworks to pass in...

@vietj what would be the best place to add `PcapWriteHandler` to the pipeline? Asking because when I added it in the same place as the `LoggingHandler`, things did not work...

I am wondering what the proper place in Vertx is for adding the `PcapWriteHandler` to the Netty processing pipeline is. If I just add it in the same places where...

I'll have to build everything again and capture it. I'll to do that later on today or tomorrow.

https://github.com/geoand/vert.x/tree/4.2.2-custom is what I had done. But in order to get that working, I needed to also patch Netty and implement `handlerAdded` in `PcapWriteHandler` to simply do what `channelActive` does

Exactly, that is how I understood the issue

I didn't, but I assume that could work.

Yup, for sure. I'll take another look tomorrow

I have asked on https://github.com/netty/netty/issues/10385 to see if it's safe to implement `handlerAdeed` as well. I asked because I was seeing some weird behavior which I am not sure is...