Georgios Andrianakis comments

Results 773 comments of


                                            Georgios Andrianakis

RESTEasy Reactive - prevent repeating of standard security checks

> I mean why do we need to keep the annotations anyway +1

Introduce support for pcap traffic capturing of network traffic

Good point. I'll have a look on Monday

Introduce support for pcap traffic capturing of network traffic

Capturing also add to the `NetClientImpl` pipeline

Introduce support for pcap traffic capturing of network traffic

Indeed, PR updated

Introduce support for pcap traffic capturing of network traffic

@vietj is there anything else that this PR needs, or should I mark it ready for review?

Introduce support for pcap traffic capturing of network traffic

> it seems to me that when a channel is closed it will close the underlying output stream and all other concurrent channel use will not be able to write...

Introduce support for pcap traffic capturing of network traffic

Fair points, I'll come back tomorrow with answers

Introduce support for pcap traffic capturing of network traffic

> what happens incase of HTTPS(SSL/TLS), can we have ability dump encrypted message? Yes, the messages are shown decrypted (in my original screenshot, one of the HTTP calls is actually...

Introduce support for pcap traffic capturing of network traffic

It seems like this does have issues with concurrent writes. I'll have to investigate further

Introduce support for pcap traffic capturing of network traffic

The only reliable way I have found so far to get this to work for multiple event loop threads under load is have each instance write to its own file...