Georgios Andrianakis

Results 773 comments of Georgios Andrianakis

I can implement this, but since there are multiple ways of doing it, I would like @iocanel to confirm or deny whether the idea I had above is good or...

I'll leave this one to you folks :). If you want me to implement something, just give me a heads up :)

Hm... This should work... We even use it in some of our tests: https://github.com/quarkusio/quarkus/blob/2.3.0.Final/integration-tests/smallrye-opentracing/src/main/java/io/quarkus/it/opentracing/JdbcResource.java#L16

Then where does the type come from?

Hello, That sounds reasonable to me, but @pavolloffay is the opentracing expert here :)

@whiskeysierra would you be interested in contributing that?

@lubinson Since you have already done an initial investigation and have an idea of how to fix the problem, care to create a PR for it? Thanks

Hi, Thanks for the contribution. Can you please explain the rationale behind these changes?

I see thanks. Could you please add a test as was requested in the original PR?

@pavolloffay do you remember? I think you added that piece of code.