web-mapviewer icon indicating copy to clipboard operation
web-mapviewer copied to clipboard

PB-1595: showing mouse coordinates in 3D:

Open ltkum opened this issue 9 months ago • 1 comments

Issues :

  • We were sending 3 pairs of Coordinates to the format function while in 3D, and the function could only handle two
  • The is3DReady flag was sometimes ready before the viewer could be accessed, leading to a situation where the handler could not be set up

Fixes :

  • We're splitting the coordinates and adding the rounded height at the end of it. (the height is optional IMO)
  • We set a timeOut function which call itself while the viewer is not ready to ensure the viewer is ready before we set the handler.

meh

Test link

ltkum avatar Apr 14 '25 14:04 ltkum

web-mapviewer    Run #5121

Run Properties:  status check passed Passed #5121  •  git commit 2285b9f21d: Merge pull request #1297 from geoadmin/fix-PB-1595-show-mouse-coordinates-in-3D
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #5121
Run duration 01m 23s
Commit git commit 2285b9f21d: Merge pull request #1297 from geoadmin/fix-PB-1595-show-mouse-coordinates-in-3D
Committer Martin Künzi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

cypress[bot] avatar Apr 14 '25 14:04 cypress[bot]