web-mapviewer icon indicating copy to clipboard operation
web-mapviewer copied to clipboard
Published 1 week ago • verified publisher icon geoadmin

PB-856 : add a style selector for KML in layer settings

Open pakb opened this issue 1 year ago • 2 comments

this enables users to opt-out of the default style (Google Earth like) we apply by default to external KML, and let them go back to the GeoAdmin (all red) style that was previously (on mf-geoadmin3) applied across the board.

adding this choice to the layer URL extra attributes

Test link

pakb avatar Aug 30 '24 12:08 pakb

web-mapviewer    Run #3872

Run Properties:  status check passed Passed #3872  •  git commit f26ca6b20a: PB-856 : add a style selector for KML in layer settings
Project web-mapviewer
Branch Review feat-PB-856-add-kml-style-selector
Run status status check passed Passed #3872
Run duration 04m 46s
Commit git commit f26ca6b20a: PB-856 : add a style selector for KML in layer settings
Committer Pascal Barth
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 212
View all changes introduced in this branch ↗︎

cypress[bot] avatar Aug 30 '24 12:08 cypress[bot]

@pakb @hansmannj With styling and icons we might have a general issue with the introduction of babs icons, this PR (kml style selector) and PB-64 self-contained KML. I did not yet check and tested the babs icon for legacy icons, but did you think about this ? What happen if you open and edit a drawing with legacy babs icon ? Currently (at least before babs icon implementation) the icon selector was a mapping between icon url from the drawing and our icons service which only work if the url was found in our service, now with legacy unlisted icons what do we do ? The same question will also apply for self-contain kml where the icon might not be found in our service-icons if we deprecated them, what do we do in this case ? The response of these questions might impact the style selector, we should have a discussion about this tomorrow.

ltshb avatar Sep 16 '24 05:09 ltshb

I tried to load Rossier.kml from the JIRA ticket, but it doesn't allow me anymore. It works in production image

ismailsunni avatar Oct 02 '24 08:10 ismailsunni

@pakb @ismailsunni @ltshb : What's the status here? I think the issues with the BABS icons should be solved. We keep on providing the old icons but unlist them in the viewer. What else needs to be clarified for this PR to be merged?

hansmannj avatar Nov 04 '24 08:11 hansmannj

using this PR test link:

  • I no longer able to load KML file using the import file tool, but I can still load it by using drag and drop

ismailsunni avatar Nov 04 '24 09:11 ismailsunni