web-mapviewer icon indicating copy to clipboard operation
web-mapviewer copied to clipboard

PB-804 : don't center on search query when sharing position - #patch

Open ltkum opened this issue 1 year ago • 1 comments

Issue : When sharing a position, if there was a search query set, the search query would take priority over the position sharing, removing the shared position pin and centering on the search query result instead. Fix : When a position is shared, it sets the marker url parameter, which means we can decide that when a marker is present, we should not center on the query result.

Test link

ltkum avatar Aug 05 '24 08:08 ltkum

web-mapviewer    Run #3298

Run Properties:  status check passed Passed #3298  •  git commit b75e406ff4: Merge pull request #1017 from geoadmin/bugfix-PB-804-dont-follow-search-on-posit...
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #3298
Run duration 05m 13s
Commit git commit b75e406ff4: Merge pull request #1017 from geoadmin/bugfix-PB-804-dont-follow-search-on-posit...
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 210
View all changes introduced in this branch ↗︎

cypress[bot] avatar Aug 05 '24 08:08 cypress[bot]

there's still some issues with the notation crosshair=x,y, see https://sys-map.int.bgdi.ch/preview/bugfix-pb-804-dont-follow-search-on-position-sharing/index.html#/map?swisssearch=2672000,1216250&center=2557000,1196750&crosshair=2557000,1196750

it should open the viewer over lake Neuchatel, but is still moving to the searched coordinates instead

Found out the issue and it should now work as expected

ltkum avatar Sep 02 '24 09:09 ltkum