web-mapviewer icon indicating copy to clipboard operation
web-mapviewer copied to clipboard

Regression of PR885 - Flight tracks are unexpectedly clampedToGround

Open t0b3 opened this issue 1 year ago • 2 comments

PR https://github.com/geoadmin/web-mapviewer/pull/885 introduced a regression:

  • flight tracks are unexpectedly clampedToGround

state before PR#885 == expected result https://sys-map.dev.bgdi.ch/preview/bug_pb-562_wrong_external_kml_style/index.html#/map?sr=3857&center=802000,5970370&camera=7.204872,47.173075,1477,-5,51,&z=17&3d&bgLayer=ch.swisstopo.swisstlm3d-karte-farbe_3d&layers=KML%7C208_Weissenstein_20_07_2024.kml image

state after PR#885 == actual result https://sys-map.dev.bgdi.ch/preview/bug_pb-591_3d_kml_improvments/index.html#/map?sr=3857&center=802000,5970370&camera=7.204872,47.173075,1477,-5,51,&z=17&3d&bgLayer=ch.swisstopo.swisstlm3d-karte-farbe_3d&layers=KML%7C208_Weissenstein_20_07_2024.kml image

unfortunately theese two overrides ignore existing KML settings like <altitudeMode>absolute</altitudeMode> and opacity https://github.com/geoadmin/web-mapviewer/blob/1428f4f27fa6489868c0d19fab2d32cbe3b1b6c0/src/modules/map/components/cesium/CesiumKMLLayer.vue#L54-L55

while clampToGround may make a lot of sense in some cases - for polylines it's not generally applicable ;-)

nb: does cesium parse altitudeMode well enough, doesn't it?

t0b3 avatar Jul 31 '24 15:07 t0b3

@t0b3 thanks for notifying us, we will have a look at it.

ltshb avatar Aug 05 '24 06:08 ltshb

Internal ticket created at PB-865

ltshb avatar Aug 05 '24 06:08 ltshb

Hi @t0b3 , could you give a try on this Test link with the file you linked above? As it is a local file, it wasn't shared with us. And I couldn't test it myself

pakb avatar Aug 30 '24 13:08 pakb

@pakb while the path is now visible in the correct altitude :+1: image let me share those observations:

  • no terrain visible i.e. if chosen SWISSIMAGE or SWISSALTI3D
  • the opacity from the KML is not respected but overriden and set to 0.5

t0b3 avatar Aug 30 '24 13:08 t0b3

Will be deployed in the next couple days on map.geo.admin.ch (I still have to found out why no background was shown in 3D)

pakb avatar Sep 02 '24 06:09 pakb

@t0b3 it should now be available on https://map.geo.admin.ch if you want to test it again

pakb avatar Sep 02 '24 14:09 pakb

the issue with KML is a known bug in 3D, but we sadly don't have an easy fix for that, we will be working more on 3D for the next version

pakb avatar Sep 02 '24 14:09 pakb

@pakb thanks for the fix :smile: it works like a charm on PROD now (as you mentioned except for KML opacity)

t0b3 avatar Sep 02 '24 18:09 t0b3