mf-geoadmin3
mf-geoadmin3 copied to clipboard
geoadmin
[3D] KML icons not completely shown
All Browser all OS
open
https://map.geo.admin.ch/?topic=ech&lang=fr&bgLayer=ch.swisstopo.swissimage&layers=KML%7C%7Chttps:%2F%2Fpublic.geo.admin.ch%2FHfMpusq3QK2fBE72T6VxUw&X=258499.00&Y=577832.38&zoom=7
result
not text and icon not shown, might be related to https://github.com/geoadmin/mf-geoadmin3/issues/3531
clearly a prio one as it affects all icons of all kmls when loaded via permalink
For some reasons it is due to this commit https://github.com/geoadmin/mf-geoadmin3/commit/dc76b58b9d768707b0d563dd6b4bf319eb7567d0
Why did we merge that guys with the emergency deploy.
https://mf-geoadmin3.int.bgdi.ch/teo_up/index.html?%3Ftopic=ech&lang=fr&bgLayer=ch.swisstopo.swissimage&X=258499.00&Y=577832.38&zoom=7&topic=ech&layers=KML%7C%7Chttps:%2F%2Fpublic.geo.admin.ch%2FHfMpusq3QK2fBE72T6VxUw
That's the deployed branch of this pull request https://github.com/geoadmin/mf-geoadmin3/pull/3528
I merged the angulare update this morning. Emergency deploy should have ben based on r_161005 tag. I thought you did that? @oterral? Generally, emergency deploys should always come from branches based on release tag. Not good. Am 06.10.2016 8:31 nachm. schrieb Gasser Loïc [email protected]:For some reasons it is due to this commit dc76b58
Why did we merge that guys with the emergency deploy.
—You are receiving this because you were assigned.Reply to this email directly, view it on GitHub, or mute the thread.
Don't take into account my previous comments
well it seems to be the case in fact: https://github.com/geoadmin/mf-geoadmin3/compare/r_161005...r_161005_hotfixes
I don't know what's going on, you can confirm but: (make cleanall user each time)
git reset --hard 037912cfa39efed3d86e4b7c5a70c9fc578c119e 037912cfa39efed3d86e4b7c5a70c9fc578c119e
It works
git reset --hard 5642411962b8f262366af9b431a95c4322815e23 5642411962b8f262366af9b431a95c4322815e23
It doesn't
something about spatial index not set to true, but I think it's need for the drawing.
It is also in yesterday's release https://map.geo.admin.ch/master/83a10e0/1610051246/index.html?topic=ech&lang=fr&bgLayer=ch.swisstopo.swissimage&X=258649.31&Y=578109.68&zoom=9&layers=KML%7C%7Chttps:%2F%2Fpublic.geo.admin.ch%2FHfMpusq3QK2fBE72T6VxUw
I scoped it out, though I cannot tell why it is the way it is yet. It seems that since https://github.com/geoadmin/mf-geoadmin3/commit/5642411962b8f262366af9b431a95c4322815e23 even though it's not super obvious it has some side effects on https://github.com/geoadmin/mf-geoadmin3/blob/master/src/components/map/MapService.js#L1385 which is maybe just unstable all together.
We don't use spatial index for several reasons:
- allow display of azimuth
- the other one https://github.com/geoadmin/mf-geoadmin3/pull/3307
@gjn Here is a hot fix https://github.com/geoadmin/mf-geoadmin3/commit/cca48c044fb6985c27fb4b9afd914df2e12379d5 you can decide to cherry-pick and deploy tomorrow unless you find a better solution.
@gjn Here is a Test Link
You can also create a PR from: https://github.com/geoadmin/mf-geoadmin3/compare/gal_master_fix_3536?expand=1
Thanks Loic for the analysis and the fix. It seems to work.
Anyhow: @oterral Could you review https://github.com/geoadmin/mf-geoadmin3/pull/3541
I've cherry-picked this commit for the hotfix branch as well, created PR for hotfix branch and am now deploying this to prod.
@oterral Especially, I wonder why the unrelated commit had such an effect. This is very strange.
This is now fixed on prod and in master. I'll close. Thanks alot @loicgasser for the fix!
this one https://github.com/geoadmin/mf-geoadmin3/commit/5642411962b8f262366af9b431a95c4322815e23 ? As you both said it's unrelated to KML display so it can't be the problem. For me this kind of commit could be the problem: https://github.com/openlayers/ol3/pull/5768
