Geoff Genz

Results 165 comments of Geoff Genz

@matthax Thinking through this if you really need per query timeouts they should be added into the QueryContext (even though it has so many properties already). My provider function idea...

Thanks for reporting this. I need to rethink the setup approach a bit because way too many things are being automatically imported -- Channels shouldn't be initialized in the setup...

Fixed saved passwords in Firefox. Other browsers still won't ask to save your password, this is a known issue with Chrome which doesn't flag POST requests without navigation as possible...

I don't claim to fully understand this project :), but I think this PR correctly uses `dbt-clickhouse` and not the `airflow-clickhouse-plugin`? Mapping values to the dbt-profile seems perfectly acceptable based...

To clarify, I think that error detection with standard/streaming queries using Native format is working correctly. The issues identified in https://github.com/ClickHouse/ClickHouse/issues/75175 would only affect queries using the `raw_query` client method,...

What does that mean? The clickhouse clients don't have support for falling back to other hosts.

Ah, I understand. Just to clarify, this works in superset with `clickhouse-driver`? In any case, I think that makes this a duplicate of #74?

the rename2 message is just information. This is almost certainly an unrelated bug. Can you create a small reproducible example from your project?

I don't understand why these messages don't print more details :( ``` 13:09:20 dbt_clickhouse adapter: Unexpected server exception dropping table 13:09:20 dbt_clickhouse adapter: Error running SQL: macro list_schemas ``` Is...

Agreed that we should be catching that error and printing something more useful in the logs. We'll take a look.