guru icon indicating copy to clipboard operation
guru copied to clipboard
verified publisher icon gentoo

dev-python/pyicloud new package

Open vitaly-zdanevich opened this issue 6 months ago • 10 comments

From https://github.com/onkelbeh/HomeAssistantRepository/tree/master/dev-python/pyicloud

vitaly-zdanevich avatar Jun 17 '25 18:06 vitaly-zdanevich

It's not acceptable to just make a copy-paste and expect it would be merged. You can close this PR, or look for yourself what is wrong and fix it.

stkw0 avatar Jun 17 '25 21:06 stkw0

@stkw0 removed <maintainer>, what else?

vitaly-zdanevich avatar Jun 18 '25 00:06 vitaly-zdanevich

Fixed dependencies.

vitaly-zdanevich avatar Jun 18 '25 00:06 vitaly-zdanevich

Starting with the most formal things:

  • commit don't have the Signed-off-by tag
  • The change to the DESCRIPTION makes it more obscure to understand what is this package about
  • you just copy-pasted a pretty old version, why you didn't even cared to update it?
  • we only store the hashes for DIST entries, not EBUILD or MISC. Metadata file should be regenerated
  • Yes, the maintainer file was wrong, it is still wrong as it should have the maintainer needed comment.
  • As you might have noticed, the minimum python version was being moved to pyhon3_11
  • you clearly didn't run pkgcheck, which is supposed to be a tool to help find common mistakes
  • KEYWORDS should only list the arch that has been tested. And you probably didn't test the arm ones
  • (maybe something else I miss)

Most of it, individually, could be taken as a small slip. However, in this case it was clearly not a mistake but a total carelessness. Even worst given that you have been around for ¿years? so you were probably aware of the most basic things (so it's not because of ignorance). As a result, I think you are not competent enough and that it would be bad for the maintenance of the repository to add your ebuilds or the ones you send, unless there is a more capable person that is willing to take care of maintaining them.

I would not review or merge your PR that adds a new package from now on, and it's my opinion that you should avoid sending PR for new packages (and close the ones that add new packages).

stkw0 avatar Jun 18 '25 00:06 stkw0

you just copy-pasted a pretty old version, why you didn't even cared to update it?

You did not check the upstream https://github.com/picklepete/pyicloud - 1.0.0 is the latest version.

vitaly-zdanevich avatar Jun 18 '25 14:06 vitaly-zdanevich

Fixed everything.

vitaly-zdanevich avatar Jun 18 '25 14:06 vitaly-zdanevich

Last version is the 2.0.1 from 4 days ago. See https://pypi.org/project/pyicloud/#history, https://github.com/timlaing/pyicloud and github.com/pypi/support/issues/5377

stkw0 avatar Jun 18 '25 14:06 stkw0

Replaced the upstream.

vitaly-zdanevich avatar Jun 18 '25 14:06 vitaly-zdanevich

close the ones that add new packages

https://github.com/gentoo/guru/pull/298 is needed to fix Organicmaps https://github.com/gentoo/guru/pull/297

vitaly-zdanevich avatar Jun 18 '25 14:06 vitaly-zdanevich

Replaced the upstream.

Not in metadata.xml

MrRoy avatar Jun 18 '25 21:06 MrRoy