guru icon indicating copy to clipboard operation
guru copied to clipboard

add package openlitespeed

Open KotoishiHeart opened this issue 8 months ago • 8 comments

What to do if you don't have php and eselect-php support?

KotoishiHeart avatar Apr 28 '25 13:04 KotoishiHeart

What to do if you don't have php and eselect-php support?

Can you explain a bit more what do you mean? What are you trying to achieve and how is openlitespeed related?

stkw0 avatar Apr 30 '25 08:04 stkw0

Can you explain a bit more what do you mean? What are you trying to achieve and how is openlitespeed related?

Openlitespeed requires a special php that supports litespeed. The currently available PHP is not compatible with Litespeed. The default PHP provided by openlitespeed is version 5.6 with no support.

Openlitespeed cannot be run with just the ebuild you add. Is it possible to put openlitespeed in guru?

KotoishiHeart avatar Apr 30 '25 12:04 KotoishiHeart

Openlitespeed requires a special php that supports litespeed.

It looks like PHP has support for litespeed, but it needs to be enabled at compile-time. The best solution would be to submit a separate pull request to ::gentoo, adding a litespeed USE flag so that this package can depend on dev-lang/php[litespeed].

Unfortunately I don't think the alternative solutions to provide PHP are good fits for GURU, since they would mean either creating an entirely separate PHP ebuild in ::guru solely to support litespeed, bundling a custom build of PHP with openlitespeed, or expecting the user to provide their own PHP installation.

Theoretically you could add openlitespeed without providing any PHP support, but I'd probably try to get a USE flag added in ::gentoo first, since otherwise it leaves potential users in an awkward situation here.

demize avatar May 02 '25 01:05 demize

As a workaround until litespeed support is added, would it be better to install the official lsphp8.1 package for ubuntu?

KotoishiHeart avatar May 03 '25 02:05 KotoishiHeart

As a workaround until litespeed support is added, would it be better to install the official lsphp8.1 package for ubuntu?

Ultimately this is just a webserver, so I don’t think we should block adding it because there’s no easy way to build support for it with PHP in ::gentoo.

I don’t think we can add or include our own PHP server in ::guru, either as part of this package or as its own package, since it would conflict with the duplicates policy. And I don’t want to hold this up myself, so if we can add it without any PHP support (unless the user installs a custom build), I think that’s fine for now. Did you (or are you planning to) open a PR in ::gentoo to add the USE flag?

Either way, @stkw0 has provided a lot more feedback already, so if he doesn’t have any objections to adding as-is then don’t worry about me :)

demize avatar May 08 '25 14:05 demize

I think it's worthy to send a PR to ::gentoo adding the litespeed support, as it may be useful for other cases and would simplify things. Mixing a source ebuild and a pre-built binary from Ubuntu is a bit of a mess.

btw the current PR still has a number of issues (will add some more comments). There is no sign-off tag and there are two Metadata files for acct-user and acct-group ebuilds that should not be there. Is there a need to add both, openlitespeed version 1.8.1 and version 1.8.3.1?

stkw0 avatar May 08 '25 16:05 stkw0

Is there a need to add both, openlitespeed version 1.8.1 and version 1.8.3.1?

There's no need. It works only with Version 1.8.3.1.

Did you (or are you planning to) open a PR in ::gentoo to add the USE flag?

I don't have the code knowledge to open a PR to add the litespeed flag to "eselect-php" or "php", and I don't have the time to do the work for that. It might be possible if you do it for a long time, but other developers might be faster to change it.

KotoishiHeart avatar May 09 '25 11:05 KotoishiHeart

There's no need. It works only with Version 1.8.3.1.

Then please, remove the other one.

I don't have the code knowledge to open a PR to add the litespeed flag to "eselect-php" or "php", and I don't have the time to do the work for that. It might be possible if you do it for a long time, but other developers might be faster to change it.

I just opened a PR to add litespeed USE to php: https://github.com/gentoo/gentoo/pull/42003

stkw0 avatar May 09 '25 12:05 stkw0