gentoo icon indicating copy to clipboard operation
gentoo copied to clipboard
verified publisher icon gentoo

sys-libs/libnbd: add 1.22.2 and 1.23.3 and fix lots of bugs

Open salahcoronya opened this issue 1 year ago • 8 comments

Dropped test dependency on sys-block/nbd. The only dependency required for test is sys-block/ndbkit. However, it will test sys-block/nbd and app=-emulationq/qemu, if present. The examples were automagically added, so made that a seperate use flag Add Python 3.13 support Add support for compiling rust binding If support for a particular for a partical feature wasn't enabled, 0 tests would be run for that, which while not fatal, produces a QA warning. Worked around it by removing what isn't select in the top-level Makefile.am with sed Test calls certtool, go net-libs/gnutls[tools] required to test.

Closes: https://bugs.gentoo.org/884245 Closes: https://bugs.gentoo.org/884247 Closes: https://bugs.gentoo.org/926647 Closes: https://bugs.gentoo.org/938348 Closes: https://bugs.gentoo.org/938349 Closes: https://bugs.gentoo.org/946553 Closes: https://bugs.gentoo.org/949324

Please check all the boxes that apply:

  • [X] I can submit this contribution in agreement with the Copyright Policy.
  • [X] I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • [X] This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • [X] I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

salahcoronya avatar Feb 28 '25 07:02 salahcoronya

Pull Request assignment

Submitter: @salahcoronya Areas affected: ebuilds Packages affected: sys-libs/libnbd

sys-libs/libnbd: @ArsenArsen

Linked bugs

Bugs linked: 884247, 938348, 938349, 949324, 884245, 926647, 946553 Cross-linking bugs disabled due to large number of bugs linked.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-bot avatar Feb 28 '25 07:02 gentoo-bot

Pull request CI report

Report generated at: 2025-02-28 19:04 UTC Newest commit scanned: c8707efcf29d6ef602ded03f8f15252f177b908f Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/e8f8dc7/output.html

gentoo-repo-qa-bot avatar Feb 28 '25 19:02 gentoo-repo-qa-bot

I masked USE="test" on this package for sparc, because dev-ml/findlib is required and not keyworded. Technically, only if USE="ocaml test" needs it, but there no way to mask a certain combination of flags only, so this will have to do.

salahcoronya avatar Feb 28 '25 23:02 salahcoronya

Upstream accepted my patch to fix https://bugs.gentoo.org/884247 and cut a new release. The only difference between 1.22.0 and 1.22.1 is my patch.

salahcoronya avatar Mar 03 '25 20:03 salahcoronya

Pull request CI report

Report generated at: 2025-03-03 23:24 UTC Newest commit scanned: a8866525871fe12714bd49e1920125d89e071fe2 Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/9a5ef25/output.html

gentoo-repo-qa-bot avatar Mar 03 '25 23:03 gentoo-repo-qa-bot

Pull request CI report

Report generated at: 2025-05-27 02:34 UTC Newest commit scanned: c26082e7889dac4131cd4c7b35b229dd671d34ba Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/6b6dee1/output.html

gentoo-repo-qa-bot avatar May 27 '25 02:05 gentoo-repo-qa-bot

I've redone the ebuild. Instead of using "sed" to conditionally patch Makefile.am, the correct conditionals have been added to Makefile.am. An additional conditional was been added to configure.ac to suppress building of the example and add a --enable-examples switch.

salahcoronya avatar Jun 15 '25 02:06 salahcoronya

Pull request CI report

Report generated at: 2025-06-15 03:23 UTC Newest commit scanned: 0747e21709af55796dae1740e0128d0c4a4f8bfc Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/08d28fe/output.html

gentoo-repo-qa-bot avatar Jun 15 '25 03:06 gentoo-repo-qa-bot

I've gone ahead and merged it given the ACK above and it's a clear improvement. Thank you and hope that's OK @ArsenArsen.

thesamesam avatar Jun 26 '25 20:06 thesamesam