gentoo icon indicating copy to clipboard operation
gentoo copied to clipboard

dev-php/PEAR-Net_LDAP2: update EAPI 6 -> 8

Open hydrapolic opened this issue 1 year ago • 5 comments

--- PEAR-Net_LDAP2-2.2.0-r1.ebuild      2024-06-13 16:23:19.505949290 +0000
+++ PEAR-Net_LDAP2-2.2.0-r2.ebuild      2024-06-13 16:30:54.973874330 +0000
@@ -1,23 +1,21 @@
 # Copyright 1999-2024 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
-EAPI=6
+EAPI=8
 
 MY_PN="${PN/PEAR-/}"
-KEYWORDS="amd64 arm ~hppa ppc64 sparc x86"
+
 DESCRIPTION="OO interface for searching and manipulating LDAP-entries"
 HOMEPAGE="https://pear.php.net/package/Net_LDAP2"
-SRC_URI="http://download.pear.php.net/package/${MY_PN}-${PV}.tgz"
+SRC_URI="https://download.pear.php.net/package/${MY_PN}-${PV}.tgz"
+S="${WORKDIR}/${MY_PN}-${PV}"
 LICENSE="LGPL-2.1"
 SLOT="0"
-IUSE="examples test"
-RESTRICT="!test? ( test )"
+KEYWORDS="~amd64 ~arm ~hppa ~ppc64 ~sparc ~x86"
+IUSE="examples"
 
 RDEPEND="dev-lang/php:*[ldap]
        dev-php/PEAR-PEAR"
-DEPEND="test? ( ${RDEPEND} dev-php/phpunit )"
-
-S="${WORKDIR}/${MY_PN}-${PV}"
 
 src_install() {
        use examples && dodoc -r doc/examples
@@ -25,7 +23,3 @@
        insinto /usr/share/php
        doins -r Net
 }
-
-src_test() {
-       phpunit tests/ || die "test suite failed"
-}


Please check all the boxes that apply:

  • [x] I can submit this contribution in agreement with the Copyright Policy.
  • [x] I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • [x] This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • [x] I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

hydrapolic avatar Jun 13 '24 16:06 hydrapolic

Pull Request assignment

Submitter: @hydrapolic Areas affected: ebuilds, profiles Packages affected: dev-php/PEAR-Net_LDAP2

dev-php/PEAR-Net_LDAP2: ~~[php-bugs (project)]~~

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

Bugs linked: 933998


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

gentoo-bot avatar Jun 13 '24 16:06 gentoo-bot

Pull request CI report

Report generated at: 2024-06-13 16:51 UTC Newest commit scanned: 570d5f1b891568fb6b7fdc58bcd816770b681feb Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/76bf366385/output.html

gentoo-repo-qa-bot avatar Jun 13 '24 16:06 gentoo-repo-qa-bot

Hello @ceamac

hydrapolic avatar Jun 13 '24 17:06 hydrapolic

Hi @hydrapolic , thank you for your work. I won't merge this package, it's not really needed by anyone and it will stay unmaintained and will keep rotting.

ceamac avatar Jun 23 '24 06:06 ceamac

Hi @hydrapolic , thank you for your work. I won't merge this package, it's not really needed by anyone and it will stay unmaintained and will keep rotting.

Hi @ceamac, actually it's used by Roundcube which is in the tree (as an optional dependency).

hydrapolic avatar Jun 23 '24 13:06 hydrapolic

This PR misses the main point of the last rite, which isn't specifically that the packages are EAPI 6, but more generally that they don't have committed maintainers.

If roundcube can use this package and the maintainers of roundcube care about keeping that working, perhaps they would be interested in maintaining the package. If not, then I agree with @ceamac that there's not a huge motivation to keep it around and we should proceed with the removal.

@titanofold @candrews may want to weigh in here.

eli-schwartz avatar Jul 08 '24 00:07 eli-schwartz

Interestingly it is NOT listed as an optfeature...

eli-schwartz avatar Jul 08 '24 00:07 eli-schwartz

Interestingly it is NOT listed as an optfeature...

It has a bundled copy.

ceamac avatar Jul 08 '24 04:07 ceamac

Just tested Roundcube with dev-php/PEAR-Net_LDAP2 removed and it works fine since it's really bundled in vendor/pear/net_ldap2. Since this was my only use case, I'm closing it.

Thanks for the help!

hydrapolic avatar Jul 08 '24 06:07 hydrapolic