gentoo icon indicating copy to clipboard operation
gentoo copied to clipboard

media-sound/gstreamripper: Fix C99 errors; update EAPI 7 -> 8

Open NHOrus opened this issue 10 months ago • 5 comments

There was a number of implicit declarations and wrongs made with pointer assignments. Patch fixes them, also supercedes previous pull request with wrongly made casts by correct functions from glib.

Closes:https://bugs.gentoo.org/871012 Closes:https://bugs.gentoo.org/919182 Closes:https://bugs.gentoo.org/885531 Closes:#30057

NHOrus avatar Apr 03 '24 17:04 NHOrus

Pull Request assignment

Submitter: @NHOrus Areas affected: ebuilds Packages affected: media-sound/gstreamripper

media-sound/gstreamripper: @gentoo/sound

Linked bugs

Bugs linked: 885531, 871012, 919182


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

gentoo-bot avatar Apr 03 '24 17:04 gentoo-bot

Pull request CI report

Report generated at: 2024-04-03 18:30 UTC Newest commit scanned: deda67b09214e6bf9e1fdd64763ece32ceeaf425 Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/feb26bc496/output.html

gentoo-repo-qa-bot avatar Apr 03 '24 18:04 gentoo-repo-qa-bot

Pull request CI report

Report generated at: 2024-04-04 12:15 UTC Newest commit scanned: 938231e0b5e79888d128bf97fae79ca4b6d0c115 Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/a388cfb1bd/output.html

gentoo-repo-qa-bot avatar Apr 04 '24 12:04 gentoo-repo-qa-bot

Rebase now that https://github.com/gentoo/gentoo/pull/36079 is merged?

thesamesam avatar May 09 '24 00:05 thesamesam

Pull request CI report

Report generated at: 2024-05-09 08:44 UTC Newest commit scanned: 3d6b86e638d90a27c4ba6686b0ba591d7717d161 Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/de3afbaac3/output.html

gentoo-repo-qa-bot avatar May 09 '24 08:05 gentoo-repo-qa-bot

@NHOrus thanks! i dropped the old version and went straight to stable. also, some arches were not present in the pr so i put them there. on emerge, i get this qa notice:

 * QA Notice: Found the following implicit function declarations in configure logs:
 *   /var/tmp/portage/media-sound/gstreamripper-0.2-r1/work/GStreamripperX-0.2/config.log:285 - exit
 * Check that no features were accidentally disabled.
 * See https://wiki.gentoo.org/wiki/Modern_C_porting.
 * ```

fordfrog avatar Jun 29 '24 10:06 fordfrog

Ok, I'll check that soon-ish

NHOrus avatar Jun 30 '24 06:06 NHOrus