gentoo icon indicating copy to clipboard operation
gentoo copied to clipboard

dev-java/junit: add 4.13.2_p20230501 to allow jdk:21

Open vaukai opened this issue 1 year ago • 4 comments

Bug: https://bugs.gentoo.org/916398

vaukai avatar Feb 22 '24 00:02 vaukai

Pull request CI report

Report generated at: 2024-02-22 00:33 UTC Newest commit scanned: 8e43c11a1d705fda86637bedfaf5bad9fe75c57c Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/cc570dde06/output.html

gentoo-repo-qa-bot avatar Feb 22 '24 00:02 gentoo-repo-qa-bot

Pull request CI report

Report generated at: 2024-02-22 00:48 UTC Newest commit scanned: 16c5066841e5b77a5c688cc064ad63c8ce7b46ea Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/36f66eae4a/output.html

gentoo-repo-qa-bot avatar Feb 22 '24 00:02 gentoo-repo-qa-bot

Pull request CI report

Report generated at: 2024-02-22 11:28 UTC Newest commit scanned: 8e4802bb5dc47ac408fe389f9e4d6e34dd2a4364 Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/b4c4a8e031/output.html

gentoo-repo-qa-bot avatar Feb 22 '24 11:02 gentoo-repo-qa-bot

Pull request CI report

Report generated at: 2024-04-06 19:40 UTC Newest commit scanned: 82c462569d951e0df97b44107c856d79f56482d3 Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/e2d056684f/output.html

gentoo-repo-qa-bot avatar Apr 06 '24 19:04 gentoo-repo-qa-bot

Pull request CI report

Report generated at: 2024-04-08 17:57 UTC Newest commit scanned: bd80724d310adde25cc3fdd4185b2da807e6ee4b Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/934e1a99f1/output.html

gentoo-repo-qa-bot avatar Apr 08 '24 17:04 gentoo-repo-qa-bot

@fordfrog this one might please be the next of my PRs to get merged. the junit5 update was overdue since ages, the junit4 update to snapshot allows removing the jdk restriction at the cost of one failing test which i had to patch out. the junit3 commit is just a minor style update including EAPI 7 -> 8.

vaukai avatar Apr 10 '24 18:04 vaukai

junit-5 fails the tests for me:

>>> Test phase: dev-java/junit-5.10.2
removed 'example/IgnoredTestsDemo.java'
removed 'example/DocumentationTestSuite.java'
removed 'example/SuiteDemo.java'
removed 'example/JUnit4Tests.java'
removed 'example/JUnitPlatformClassDemo.java'
removed 'example/JUnitPlatformSuiteDemo.java'
removed 'example/testkit/EngineTestKitAllEventsDemo.java'
removed 'example/testkit/EngineTestKitFailedMethodDemo.java'
removed 'example/testkit/EngineTestKitSkippedMethodDemo.java'
removed 'example/testkit/EngineTestKitStatisticsDemo.java'
removed directory 'example/testkit/'
removed 'org/junit/api/tools/AbstractApiReportWriter.java'
removed 'org/junit/api/tools/ApiReport.java'
removed 'org/junit/api/tools/ApiReportGenerator.java'
removed 'org/junit/api/tools/ApiReportWriter.java'
removed 'org/junit/api/tools/AsciidocApiReportWriter.java'
removed 'org/junit/api/tools/HtmlApiReportWriter.java'
removed 'org/junit/api/tools/MarkdownApiReportWriter.java'
removed directory 'org/junit/api/tools/'
removed 'example/HamcrestAssertionsDemo.java'
removed 'example/session/HttpTests.java'
javac -source 1.8 -target 1.8 -d /var/tmp/portage/dev-java/junit-5.10.2/temp/junit5_src_test/classes -encoding UTF-8 -classpath /usr/share/apiguardian-api/lib/apiguardian-api.jar:/usr/share/opentest4j/lib/opentest4j.jar:/usr/share/open-test-reporting-events/lib/open-test-reporting-events.jar:/usr/share/picocli/lib/picocli.jar:/usr/share/univocity-parsers/lib/univocity-parsers.jar:/usr/share/open-test-reporting-schema/lib/open-test-reporting-schema.jar::/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-commons/junit-platform-commons.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-engine/junit-platform-engine.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-launcher/junit-platform-launcher.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-reporting/junit-platform-reporting.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-console/junit-platform-console.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-api/junit-jupiter-api.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-engine/junit-jupiter-engine.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-params/junit-jupiter-params.jar @/var/tmp/portage/dev-java/junit-5.10.2/temp/junit5_src_test/sources.lst
warning: [options] bootstrap class path not set in conjunction with -source 8
warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
4 warnings
javac -source 1.8 -target 1.8 -d /var/tmp/portage/dev-java/junit-5.10.2/temp/junit5_src_test/test-classes -encoding UTF-8 -classpath /var/tmp/portage/dev-java/junit-5.10.2/temp/junit5_src_test/classes:documentation/src/test/resources:/usr/share/apiguardian-api/lib/apiguardian-api.jar:/usr/share/opentest4j/lib/opentest4j.jar:/usr/share/open-test-reporting-events/lib/open-test-reporting-events.jar:/usr/share/picocli/lib/picocli.jar:/usr/share/univocity-parsers/lib/univocity-parsers.jar:/usr/share/open-test-reporting-schema/lib/open-test-reporting-schema.jar::/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-commons/junit-platform-commons.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-engine/junit-platform-engine.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-launcher/junit-platform-launcher.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-reporting/junit-platform-reporting.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-platform-console/junit-platform-console.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-api/junit-jupiter-api.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-engine/junit-jupiter-engine.jar:/var/tmp/portage/dev-java/junit-5.10.2/work/junit5-r5.10.2/junit-jupiter-params/junit-jupiter-params.jar @/var/tmp/portage/dev-java/junit-5.10.2/temp/junit5_src_test/test-sources.lst
warning: [options] bootstrap class path not set in conjunction with -source 8
warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
documentation/src/test/java/example/TempDirectoryDemo.java:28: error: package com.google.common.jimfs does not exist
import com.google.common.jimfs.Configuration;
                              ^
documentation/src/test/java/example/TempDirectoryDemo.java:29: error: package com.google.common.jimfs does not exist
import com.google.common.jimfs.Jimfs;
                              ^
documentation/src/test/java/example/TempDirectoryDemo.java:135: error: cannot find symbol
			private final FileSystem fileSystem = Jimfs.newFileSystem(Configuration.unix());
			                                      ^
  symbol:   variable Jimfs
  location: class JimfsTempDirFactory
documentation/src/test/java/example/TempDirectoryDemo.java:135: error: cannot find symbol
			private final FileSystem fileSystem = Jimfs.newFileSystem(Configuration.unix());
			                                                          ^
  symbol:   variable Configuration
  location: class JimfsTempDirFactory
4 errors
4 warnings

fordfrog avatar Apr 11 '24 06:04 fordfrog

what's approved is merged now. i also reordered variables on some ebuilds to remove to pkgcheck warnings.

fordfrog avatar Apr 11 '24 06:04 fordfrog

error:

junit-5 fails the tests for me:

just added jimfs stolen from https://github.com/gentoo/gentoo/pull/33490

vaukai avatar Apr 11 '24 08:04 vaukai

Pull request CI report

Report generated at: 2024-04-11 10:24 UTC Newest commit scanned: 7bc6154bfbdf81868c393580ecb52a669db88d9f Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/73e425a9c5/output.html

gentoo-repo-qa-bot avatar Apr 11 '24 10:04 gentoo-repo-qa-bot

Pull request CI report

Report generated at: 2024-04-11 11:29 UTC Newest commit scanned: 68185d85c41ec788fd6fe9cacb00f2442f26d74e Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/c452b22535/output.html

gentoo-repo-qa-bot avatar Apr 11 '24 11:04 gentoo-repo-qa-bot

Pull request CI report

Report generated at: 2024-04-12 08:45 UTC Newest commit scanned: 04ec297223d4b458c62870be2e009538d70f2e2a Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/a3daedf7a6/output.html

gentoo-repo-qa-bot avatar Apr 12 '24 08:04 gentoo-repo-qa-bot

Pull request CI report

Report generated at: 2024-04-12 09:10 UTC Newest commit scanned: 6874975fd5e4771b1ae4fa9a0c7200eb67c2458a Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/127efea5ff/output.html

gentoo-repo-qa-bot avatar Apr 12 '24 09:04 gentoo-repo-qa-bot

problem with the tests imo is that the package misses META-INF/services file in the jar. i suggest you first build the package using maven, then check the content of the file and replicate that within the ebuild. that should fix the tests.

done.

vaukai avatar Apr 13 '24 08:04 vaukai

Pull request CI report

Report generated at: 2024-04-13 08:34 UTC Newest commit scanned: c0125cd11c9d3a75c8e7e79430cea1fa1481266e Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/a2135e224a/output.html

gentoo-repo-qa-bot avatar Apr 13 '24 08:04 gentoo-repo-qa-bot

Pull Request assignment

Submitter: @vaukai Areas affected: ebuilds Packages affected: dev-java/antlr-tool, dev-java/icu4j, dev-java/jimfs, dev-java/junit

dev-java/antlr-tool: @gentoo/java dev-java/icu4j: @gentoo/java dev-java/jimfs: @gentoo/proxy-maint (new package) dev-java/junit: @gentoo/java

Linked bugs

Bugs linked: 921398, 929903


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

gentoo-bot avatar Apr 13 '24 13:04 gentoo-bot

Pull request CI report

Report generated at: 2024-04-13 13:44 UTC Newest commit scanned: e658e37a9d867d0ec23aba3b63ba849842cd9649 Status: :white_check_mark: good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question: https://qa-reports.gentoo.org/output/gentoo-ci/ee55eacc00/output.html

gentoo-repo-qa-bot avatar Apr 13 '24 13:04 gentoo-repo-qa-bot

it's done now, i just merged junit.

fordfrog avatar Apr 14 '24 07:04 fordfrog

it's done now, i just merged junit.

sorry for those many late changes ...

vaukai avatar Apr 14 '24 07:04 vaukai