gentoo-docker-images icon indicating copy to clipboard operation
gentoo-docker-images copied to clipboard

Avoid duplicating build script across amd64 variate

Open proneetv opened this issue 10 years ago • 2 comments

Since all the amd64 variate mostly use the similar build.sh script, we should avoid duplicating it for each particular case.

The information required to generate the URL for respective amd64 variate is already available in variables ${arch} & ${suffix} here: https://github.com/gentoo/gentoo-docker-images/blob/master/amd64/build.sh#L23 which is the only difference across each such build script.

PS: addressing issue raised in #23

proneetv avatar Oct 27 '15 20:10 proneetv

Please add more information about the issue and keep the reference at the end of the description. It would be useful for those who weren't on the discussion to understand what was the issue and which PR solved it.

dastergon avatar Oct 27 '15 21:10 dastergon

Further to this issue, this whole area of automation for container image generation has been fairly maturely dealt with already over at lxc-gentoo. Recently I opened an issue about auto-generation of docker images there. Perhaps you would like to use lxc-gentoo script here? It is relatively well tested and supports great features like:

  • Not duplicating the build script (the subject of this issue)
  • Cryptographic validation

globalcitizen avatar Feb 01 '16 13:02 globalcitizen

This seems obsolete since, at the latest, 64f150f16c0eb0f549dd8381914f7b7e1cdd195b from years ago.

ajakk avatar Sep 08 '24 22:09 ajakk