gcsim

gcsim copied to clipboard

Invincibility during Dash is not implemented

1

On dash, every character should be invincible for 0.3s = 18f. HP drains like Dehya's Self DoT and Furina's E HP drain should still work though.

k0l11

https://github.com/renovatebot/renovate

k0l11

see https://github.com/genshinsim/gcsim/pull/1940#discussion_r1469468981

k0l11

Generic character dash should take `extend` as a param that gets added on-top of the base dash frames. Custom dash implementations already accept this param. Need to think about how...

k0l11

- generated output is not stable between operating systems (Windows vs Linux) - should just have all messages passed around in proto format for consistency

k0l11

https://gcsim.app/sh/NkkPgjPbfHFb 

Charlie-Zheng

1 space (prettier) vs. 2 spaces after `:` (generated by pipeline) example: https://github.com/genshinsim/gcsim/pull/1632/commits/fb2c26c2501b30c0b3a7a302a20347ea6bafadb1#diff-dbd9b1d1e51f49319cf8ff5178c4339f2a83d0d03410520502b4c9041341f939

k0l11

add .target0 conditional namespace

2

This includes the following conditionals: - `.target0.mods.[name]`: status/res/def/mods check - `.target0.element.[name]`: durability check - [ ] Verify syntax design. - [ ] Figure out how to handle deprecation better. closes...

skippi

The game is a mess so the expected proc rate of 50.2% can vary depending on ping/fps/character attack timing, see various KQM TCL entries: - https://library.keqingmains.com/evidence/equipment/artifacts#echoes-trigger-affected-by-ping-and-fps - https://library.keqingmains.com/evidence/equipment/artifacts#echoes-proc-rate-falls-off-after-100-ping This is...

k0l11

see https://github.com/simimpact/srsim/issues/132 dealing with different versions of protoc is painful

k0l11